Filling XLSX: Everything except multiple choice.

Summary

For caosdb/customers/dimr/management#219:

Filling XLSX templates from JSON works now.

Focus

• Correct handling of foreign keys
• Correct handling of other lists

Test Environment

Run the unit tests.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues
• Up-to-date CHANGELOG.md (or not necessary)
• Up-to-date JSON schema (or not necessary)
• Appropriate user and developer documentation (or not necessary)
  • How do I use the software? Assume "stupid" users.
  • How do I develop or debug the software? Assume novice developers.
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• Appropriate user and developer documentation (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

src/caosadvancedtools/table_json_conversion/table_generator.py

@@ -204,11 +204,15 @@ class TableTemplateGenerator(ABC):
                 # and add the foreign keys that are necessary up to this point
                 for array_path in array_paths:
                     foreigns = self._get_foreign_keys(foreign_keys, array_path)
+                    if isinstance(foreigns, str):
+                        raise ValueError("Foreign keys must be a list of strings, but a single "
+                                         "string was given:\n"
+                                         f"{array_path} -> {foreigns}")
                     for foreign in foreigns:
                         internal_key = p2s(array_path + [foreign])
                         if internal_key in sheets[sheetname]:
                             raise ValueError("The schema would lead to two columns with the same "
-                                             f"name, which is forbidden: {internal_key}")
+                                             f"name, which is forbidden:\n{foreign} -> {internal_key}")
                         ref_sheet = p2s(array_path)
                         sheets[sheetname][internal_key] = (
                             ColumnType.FOREIGN, f"see sheet '{ref_sheet}'", array_path + [foreign])