Skip to content
Snippets Groups Projects

ENH: xlsx template generator

Merged ENH: xlsx template generator
f-xlsx-json into f-more-jsonschema-export
2 unresolved threads
Merged Henrik tom Wörden requested to merge f-xlsx-json into f-more-jsonschema-export
2 unresolved threads

Summary

Allows to create XLSX templates

Focus

Test Environment

unit test (including one for all dimr schemas which is to be removed)

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports

Pipeline #48138 passed

Stage: setup
Stage: cert
Stage: style
Stage: unittest
Stage: integrationtest

Pipeline passed for ef005f5b on f-xlsx-json

Merged by Daniel HornungDaniel Hornung 1 year ago (Mar 5, 2024 3:32pm UTC)

Loading

Pipeline #48139 passed

Stage: setup
Stage: cert
Stage: style
Stage: unittest
Stage: integrationtest

Pipeline passed for 79500a20 on f-more-jsonschema-export

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/caosadvancedtools/table_json_conversion/fill_xlsx.py 0 → 100644
1 #!/usr/bin/env python3
  • Henrik tom Wörden
  • Henrik tom Wörden
    Henrik tom Wörden @henrik started a thread on an old version of the diff
    • src/caosadvancedtools/table_json_conversion/table_generator.py 0 → 100644
    126 raise ValueError(f"A foreign key definition is missing for path: \n{path}\n{keys}")
    127 keys = keys[cpath[0]]
    128 if isinstance(keys, list):
    129 selected_keys, keys = keys, None
    130 else:
    131 selected_keys, keys = None, keys
    132 cpath = cpath[1:]
    133 if isinstance(keys, dict) and "__this__" in keys:
    134 selected_keys = keys["__this__"]
    135
    136 if selected_keys is None:
    137 raise ValueError(f"A foreign key definition is missing for path:"
    138 f"\n{path}\n{foreign_keys}")
    139 return selected_keys
    140
    141 def _treat_schema_element(self, schema: dict, sheets: dict = None, path: list = None,
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden requested review from @daniel

    requested review from @daniel

  • Henrik tom Wörden added 1 commit

    added 1 commit

    Compare with previous version

  • Henrik tom Wörden
    Henrik tom Wörden @henrik ·
    Author Owner

    https://gitlab.indiscale.com/caosdb/customers/dimr/management/-/issues/217 https://gitlab.indiscale.com/caosdb/customers/dimr/management/-/issues/218

  • Henrik tom Wörden marked the checklist item Reference related issues as completed

    marked the checklist item Reference related issues as completed

  • Henrik tom Wörden marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Henrik tom Wörden added 1 commit

    added 1 commit

    Compare with previous version

  • Henrik tom Wörden marked the checklist item Up-to-date JSON schema (or not necessary) as completed

    marked the checklist item Up-to-date JSON schema (or not necessary) as completed

  • Henrik tom Wörden marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

  • Henrik tom Wörden marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Henrik tom Wörden added 1 commit

    added 1 commit

    Compare with previous version

  • Henrik tom Wörden added 1 commit

    added 1 commit

    • 8b14cbcf - STY: fixing linting warnings

    Compare with previous version

  • Henrik tom Wörden added 1 commit

    added 1 commit

    • 91529537 - DOC: added considerations for fill

    Compare with previous version

  • Daniel Hornung added 1 commit

    added 1 commit

    • 27dc4c62 - TEST: More extensive test data.

    Compare with previous version

  • Daniel Hornung added 1 commit

    added 1 commit

    • e1b5fd4a - TEST: Full test for hidden rows and columns.

    Compare with previous version

  • Daniel Hornung marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Daniel Hornung added 1 commit

    added 1 commit

    • c14af58f - STY: Documentation andcode styled.

    Compare with previous version

  • Daniel Hornung marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

  • Daniel Hornung added 1 commit

    added 1 commit

    Compare with previous version

  • Daniel Hornung added 1 commit

    added 1 commit

    Compare with previous version

  • Daniel Hornung marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Daniel Hornung marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

  • Daniel Hornung marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Daniel Hornung approved this merge request

    approved this merge request

  • Daniel Hornung enabled an automatic merge when the pipeline for ef005f5b succeeds

    enabled an automatic merge when the pipeline for ef005f5b succeeds

  • Daniel Hornung mentioned in commit 79500a20

    mentioned in commit 79500a20

  • Daniel Hornung merged

    merged

    • Please register or sign in to reply