Skip to content

ENH: JsonSchemaExporter accepts do_not_create parameter.

Florian Spreckelsen requested to merge f-more-jsonschema-export into dev

Summary

For https://gitlab.indiscale.com/caosdb/customers/dimr/management/-/issues/92. Adds a workaround for https://github.com/rjsf-team/react-jsonschema-form/issues/3957 to the exported json-schema by providing the option to wrap files in arrays.

Focus

Does the wrapper look good? Should we use better titles.

Test Environment

Unit test + recreating DIMR's schema with the new parameter and visiting the frontend somewhere where (a list of) files can be entered.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports