ENH: jsex: Allowing to update schemata with any other dicts.
All threads resolved!
All threads resolved!
Summary
Implemented schema update from dictionaries.
Focus
Are the tests sufficient?
Test Environment
Run the unit tests: pytest unittests/test_json_schema_exporter.py
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues caosdb/customers/dimr/management#58 -
Up-to-date CHANGELOG.md (or not necessary) -
Up-to-date JSON schema (or not necessary) -
Appropriate user and developer documentation (or not necessary) - How do I use the software? Assume "stupid" users.
- How do I develop or debug the software? Assume novice developers.
-
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Florian Spreckelsen
Merge request reports
Activity
assigned to @daniel
added 1 commit
- e8caa024 - ENH: jsex: Allowing to update schemata with any other dicts.
- Resolved by Florian Spreckelsen
- Resolved by Florian Spreckelsen
- Resolved by Florian Spreckelsen
requested review from @florian
mentioned in commit 531bca1f
Please register or sign in to reply