Skip to content
Snippets Groups Projects

ENH: JsonSchemaExporter can merge schemata and arrayize them

Merged Daniel Hornung requested to merge f-more-jsonschema-export into dev

Summary

New utility functions for the Json schema exporter

  • merging and arrays
  • file properties

Focus

Functionality

Test Environment

Look at the unit tests:

pytest unittests/test_json_schema_exporter.py -k modification

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Daniel Hornung
  • 317 318 do_not_create=do_not_create,
    318 319 )
    319 320 return exporter.recordtype_to_json_schema(rt)
    321
    322
    323 def make_array(schema: dict) -> dict:
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung marked the checklist item Reference related issues as completed

    marked the checklist item Reference related issues as completed

  • Daniel Hornung marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Daniel Hornung requested review from @florian

    requested review from @florian

  • Daniel Hornung added 1 commit

    added 1 commit

    • 82e7b342 - MAINT: Compatibility with py3.7

    Compare with previous version

  • Daniel Hornung added 1 commit

    added 1 commit

    • 96a0ab9f - ENH: Adding earlier exception, which makes debugging easier.

    Compare with previous version

  • Daniel Hornung added 2 commits

    added 2 commits

    • 12a77b94 - TEST: get_deep with inheritance
    • 6c87e4bf - FIX: get_deep now also takes parents into account.

    Compare with previous version

  • Daniel Hornung added 1 commit

    added 1 commit

    • b49696bf - FIX: importance order fixed.

    Compare with previous version

  • Daniel Hornung added 2 commits

    added 2 commits

    • f398b5d9 - ENH: Better error message.
    • 5dc99c61 - ENH: json schema export now handles file properties.

    Compare with previous version

  • Daniel Hornung marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Daniel Hornung changed the description

    changed the description

  • Daniel Hornung added 1 commit

    added 1 commit

    Compare with previous version

  • Florian Spreckelsen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading