Skip to content
Snippets Groups Projects

F schema export references

Merged F schema export references
f-schema-export-references into dev
All threads resolved!
Merged Florian Spreckelsen requested to merge f-schema-export-references into dev
All threads resolved!

Summary

For https://gitlab.indiscale.com/caosdb/customers/dimr/management/-/issues/38 Extends !80 (merged) by treatment of references and list of references.

(List of) References are translated int (arrays of) "oneOf" properties: They include a subschema for the creation of new Records of the referenced types, and an enum with the existing Records. A special case are reference properties with the generic db.REFERENCE datatype. Since here, we can't create a new Record (since we don't know a type), only the enum with all Records and Files is used.

Focus

RecordType treatment has been refactored s.th. it can be used recursively to create subschemas. Apart from this and the generation of the enum values, the existing property treatment was already enough.

Test Environment

Unit and integration tests should be sufficient but feel free to test with your favorite RT from a live system, too.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports

Pipeline #42883 passed

Stage: setup
Stage: cert
Stage: style
Stage: unittest
Stage: integrationtest

Pipeline passed for 48548b0d on f-schema-export-references

Approval is optional

Merged by Daniel HornungDaniel Hornung 1 year ago (Oct 26, 2023 2:46pm UTC)

Merge details

  • Changes merged into dev with d605fd58.
  • Deleted the source branch.

Pipeline #43093 passed

Stage: setup
Stage: cert
Stage: style
Stage: unittest
Stage: integrationtest

Pipeline passed for d605fd58 on dev

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Florian Spreckelsen
  • Florian Spreckelsen
  • Florian Spreckelsen
  • Florian Spreckelsen marked the checklist item Reference related issues as completed

    marked the checklist item Reference related issues as completed

  • Florian Spreckelsen marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Florian Spreckelsen marked the checklist item Up-to-date JSON schema (or not necessary) as completed

    marked the checklist item Up-to-date JSON schema (or not necessary) as completed

  • Florian Spreckelsen marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

  • Florian Spreckelsen marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Florian Spreckelsen requested review from @daniel

    requested review from @daniel

  • Daniel Hornung added 2 commits

    added 2 commits

    • f00c3de9 - 1 commit from branch f-simple-schema-export
    • e990d6bc - Merge branch 'f-simple-schema-export' into f-schema-export-references

    Compare with previous version

  • Daniel Hornung added 3 commits

    added 3 commits

    • e990d6bc...c01ae927 - 2 commits from branch f-simple-schema-export
    • 85e8549b - Merge branch 'f-simple-schema-export' into f-schema-export-references

    Compare with previous version

  • Daniel Hornung marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Florian Spreckelsen added 2 commits

    added 2 commits

    • 84105b9e - Merge branch 'f-simple-schema-export' into f-schema-export-references
    • a4e990c8 - Merge branch 'f-schema-export-references' of...

    Compare with previous version

  • Daniel Hornung marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Daniel Hornung resolved all threads

    resolved all threads

  • Daniel Hornung resolved all threads

    resolved all threads

  • Daniel Hornung resolved all threads

    resolved all threads

  • Daniel Hornung added 2 commits

    added 2 commits

    • 797817e0 - MAINT: Renamed a few functions.
    • 8f9a8b62 - TEST: Added test coverage reports.

    Compare with previous version

  • Daniel Hornung marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

  • Daniel Hornung marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

  • Daniel Hornung marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
    Daniel Hornung @daniel ·
    Owner

    Looks good to me, please merge whenever you want.

  • Daniel Hornung added 1 commit

    added 1 commit

    Compare with previous version

  • Florian Spreckelsen resolved all threads

    resolved all threads

  • Timm Fitschen added 4 commits

    added 4 commits

    • fcc99597...a1b4ffc9 - 3 commits from branch f-simple-schema-export
    • 48548b0d - Merge branch 'f-simple-schema-export' into f-schema-export-references

    Compare with previous version

  • Florian Spreckelsen deleted the f-simple-schema-export branch. This merge request now targets the dev branch

    deleted the f-simple-schema-export branch. This merge request now targets the dev branch

  • Daniel Hornung mentioned in commit d605fd58

    mentioned in commit d605fd58

  • Daniel Hornung merged

    merged

    • Please register or sign in to reply