Skip to content
Snippets Groups Projects

Add to existing model

Merged Add to existing model
f-add-to-existing-model into dev
1 unresolved thread
Merged Daniel Hornung requested to merge f-add-to-existing-model into dev
1 unresolved thread

Summary

Adding the YAML model to an existing data model.

Focus

No unexpected other behaviour? Does it do what it should?

Test Environment

pytest unittests/ -k existing_model

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues #110 (closed)
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Alexander Schlemmer

Merge request reports

Pipeline #40040 passed

Stage: setup
Stage: cert
Stage: style
Stage: unittest
Stage: integrationtest

Pipeline passed for d75169fc on f-add-to-existing-model

Approval is optional

Merged by Daniel HornungDaniel Hornung 1 year ago (Aug 29, 2023 9:47am UTC)

Loading

Pipeline #40041 passed

Stage: setup
Stage: cert
Stage: style
Stage: unittest
Stage: integrationtest

Pipeline passed for 1acca6c1 on dev

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Daniel Hornung
    Daniel Hornung @daniel started a thread on the diff
    • unittests/test_yaml_model_parser.py
    372 A:
    373 """
    374 model_1 = parse_model_from_string(model_str_1)
    375 model_2 = parse_model_from_string(model_str_2, existing_model=model_1)
    376 for ent in ["A", "B", "number"]:
    377 assert ent in model_2
    378
    379 model_str_redefine = """
    380 number:
    381 datatype: DOUBLE
    382 description: Hello number!
    383 """
    384 model_redefine = parse_model_from_string(model_str_redefine, existing_model=model_1)
    385 print(model_redefine)
    386 assert model_redefine["number"].description == "Hello number!"
    387 assert model_redefine["number"].datatype == db.INTEGER # FIXME Shouldn't this be DOUBLE?
  • Daniel Hornung marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Daniel Hornung requested review from @salexan

    requested review from @salexan

  • Alexander Schlemmer marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Alexander Schlemmer marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Alexander Schlemmer marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Alexander Schlemmer marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

  • Alexander Schlemmer marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

  • Alexander Schlemmer marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Alexander Schlemmer marked the checklist item Check: Are there specifications? Are they satisfied? as completed

    marked the checklist item Check: Are there specifications? Are they satisfied? as completed

  • Alexander Schlemmer
    Alexander Schlemmer @salexan ·
    Owner

    MR is fine! Can you please create and/or reference the mentioned issue (and maybe failing test) and then just hit the merge button?

  • Alexander Schlemmer approved this merge request

    approved this merge request

  • Daniel Hornung merged

    merged

  • Daniel Hornung mentioned in commit 1acca6c1

    mentioned in commit 1acca6c1

    • Please register or sign in to reply