Skip to content
Snippets Groups Projects

Resulttable

Merged Henrik tom Wörden requested to merge resulttable into dev

Summary

Add a CFood that creates a Record for each line in certain csv files

Test Environment

https://gitlab.indiscale.com/caosdb/internal/all/-/issues/81

If that works it should be sufficient.

Int test should run again once the obligatory problem is solved

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Henrik tom Wörden marked the checklist item Up-to-date CHANGELOG.md as completed

    marked the checklist item Up-to-date CHANGELOG.md as completed

  • Henrik tom Wörden marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Henrik tom Wörden assigned to @florian and unassigned @henrik

    assigned to @florian and unassigned @henrik

  • Florian Spreckelsen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Florian Spreckelsen marked the checklist item Up-to-date CHANGELOG.md as completed

    marked the checklist item Up-to-date CHANGELOG.md as completed

  • Florian Spreckelsen marked the checklist item The test environment setup works and the intended behavior is as completed

    marked the checklist item The test environment setup works and the intended behavior is as completed

  • Florian Spreckelsen marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Florian Spreckelsen marked the checklist item Check: Are there spezifications? Are they satisfied? as completed

    marked the checklist item Check: Are there spezifications? Are they satisfied? as completed

  • I approve merging this after !5 (merged) has been merged to dev, dev has been merged into resulttable, and the pipelines succeed again.

  • added 3 commits

    Compare with previous version

  • mentioned in issue #41 (closed)

  • mentioned in issue #46 (closed)

  • added 64 commits

    Compare with previous version

  • Henrik tom Wörden enabled an automatic merge when the pipeline for db13ac4e succeeds

    enabled an automatic merge when the pipeline for db13ac4e succeeds

  • Florian Spreckelsen aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • added 85 commits

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading