Skip to content
Snippets Groups Projects

ENH: include caosdbignore

Merged Henrik tom Wörden requested to merge f-caosdbignore into dev

Summary

This allows to add one (or more) caosdbignore files to define which files are inserted.

Focus

Unfortunately, we have another URI-Too-Long problem here. Thus, all desired files are collected and then regexps are created in chunks (3 files at a time) to prevent that problem. The regexp must also be more complex than simply the path of the files, since the server will stop looking at a directory if the top level dirs are not matchted themselves.

Test Environment

There are unit and integration tests. You can also bind mount (or copy) some folder structure and create your own ignore files.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Henrik tom Wörden
  • added 1 commit

    • 563e3578 - DOC: add doc strings and remove debugging output

    Compare with previous version

  • Henrik tom Wörden requested review from @florian

    requested review from @florian

  • added 1 commit

    • 70ee0bf4 - FIX: fix package name and install it in CI

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Florian Spreckelsen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • added 39 commits

    Compare with previous version

  • Florian Spreckelsen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • added 2 commits

    • eaa1e276 - STY: docstrings and changelog
    • e9609364 - DOC: Add link to gitignore documentation

    Compare with previous version

  • Florian Spreckelsen marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Florian Spreckelsen marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

  • Florian Spreckelsen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Florian Spreckelsen marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading