Skip to content

ENH: include caosdbignore

Henrik tom Wörden requested to merge f-caosdbignore into dev

Summary

This allows to add one (or more) caosdbignore files to define which files are inserted.

Focus

Unfortunately, we have another URI-Too-Long problem here. Thus, all desired files are collected and then regexps are created in chunks (3 files at a time) to prevent that problem. The regexp must also be more complex than simply the path of the files, since the server will stop looking at a directory if the top level dirs are not matchted themselves.

Test Environment

There are unit and integration tests. You can also bind mount (or copy) some folder structure and create your own ignore files.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports