MAINT: make send_mail in crawler static

Summary

I want to reuse the send_mail function. There is no reason not to have it static.

Test Environment

pipeline

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related issues https://gitlab.indiscale.com/caosdb/customers/leibniz-zmt/management/-/issues/76
• Up-to-date CHANGELOG.md (or not necessary)
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md (or not necessary)
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

src/caosadvancedtools/crawler.py

@@ -430,7 +430,7 @@ class Crawler(object):
             if "SHARED_DIR" in os.environ:
                 filename = Crawler.save_form([el[3]
                                               for el in pending_changes], path, self.run_id)
-                self.send_mail([el[3] for el in pending_changes], filename)
+                Crawler.send_mail([el[3] for el in pending_changes], filename)
 
             for i, el in enumerate(pending_changes):
 
@@ -441,8 +441,7 @@ ____________________\n""".format(i+1, len(pending_changes)) + str(el[3]))
             logger.info("There where unauthorized changes (see above). An "
                         "email was sent to the curator.\n"
                         "You can authorize the updates by invoking the crawler"
-                        " with the run id: {rid}\n".format(rid=self.run_id,
-                                                           path=path))
+                        " with the run id: {rid}\n".format(rid=self.run_id))
 
         if len(DataModelProblems.missing) > 0:
             err_msg = ("There were problems with one or more RecordType or "
@@ -562,7 +561,8 @@ ____________________\n""".format(i+1, len(pending_changes)) + str(el[3]))
             f.write(form)
         return filename
 
-    def send_mail(self, changes, filename):
+    @staticmethod
+    def send_mail(changes, filename):
         """ calls sendmail in order to send a mail to the curator about pending
         changes