Skip to content

F fix assure in list

Florian Spreckelsen requested to merge f-fix-assure-in-list into dev

Summary

For https://gitlab.indiscale.com/caosdb/internal/all/-/issues/530 (or https://gitlab.com/caosdb/caosdb-advanced-user-tools/-/issues/40). Fixes a specific bug whereby assure_object_is_in_list would fail on update when adding an object to an initially empty list.

Focus

The fix is only two lines in cfood.py and there is a new integration test reproducing the problem in https://gitlab.com/caosdb/caosdb-advanced-user-tools/-/issues/40.

Test Environment

Integration test should be sufficient, but feel free to experiment manually with similar cases (don't forget to set the global guard level to UPDATE if you want to test it manually.)

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports