Skip to content
Snippets Groups Projects

F fix assure in list

Merged Florian Spreckelsen requested to merge f-fix-assure-in-list into dev

Summary

For https://gitlab.indiscale.com/caosdb/internal/all/-/issues/530 (or https://gitlab.com/caosdb/caosdb-advanced-user-tools/-/issues/40). Fixes a specific bug whereby assure_object_is_in_list would fail on update when adding an object to an initially empty list.

Focus

The fix is only two lines in cfood.py and there is a new integration test reproducing the problem in https://gitlab.com/caosdb/caosdb-advanced-user-tools/-/issues/40.

Test Environment

Integration test should be sufficient, but feel free to experiment manually with similar cases (don't forget to set the global guard level to UPDATE if you want to test it manually.)

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Daniel Hornung

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Florian Spreckelsen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Florian Spreckelsen marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Florian Spreckelsen marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • added 1 commit

    Compare with previous version

  • Florian Spreckelsen changed the description

    changed the description

  • Florian Spreckelsen marked the checklist item Reference related issues as completed

    marked the checklist item Reference related issues as completed

  • Florian Spreckelsen requested review from @daniel

    requested review from @daniel

  • Daniel Hornung added 3 commits

    added 3 commits

    • 50e13c60 - MAINT: Made the code a bit more readable.
    • 6a402886 - TEST: Reset example files to initial state.
    • 7c7d9f43 - STY: Wrapped long lines in test.sh

    Compare with previous version

  • Daniel Hornung resolved all threads

    resolved all threads

  • Daniel Hornung added 1 commit

    added 1 commit

    Compare with previous version

  • Daniel Hornung marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Daniel Hornung marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Daniel Hornung marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Daniel Hornung marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

  • Daniel Hornung marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Daniel Hornung approved this merge request

    approved this merge request

  • LGTM, I added a few small changes. Please merge or revert at will.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading