MAINT: be more specific with output

Summary

Prevent the message that records are being inserted or updated when they are not. Now, each cfood prints how many records are inserted or updated if and only if some are changed or inserted.

Test Environment

Run the crawler in some environment.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related Issues
• Up-to-date CHANGELOG.md
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

src/caosadvancedtools/crawler.py

@@ -310,8 +310,6 @@ class Crawler(object):
         if self.interactive and "y" != input("Do you want to continue? (y)"):
             return
 
-        logger.info("Inserting or updating Records...")
-
         for cfood in cfoods:
             try:
                 cfood.create_identifiables()
@@ -544,6 +542,10 @@ carefully and if the changes are ok, click on the following link:
 
         logger.debug(cfood.to_be_updated)
         try:
+            if len(cfood.to_be_updated) > 0:
+                logger.info(
+                        "Updating {} Records...".format(
+                            len(cfood.to_be_updated)))
             guard.safe_update(cfood.to_be_updated, unique=False)
         except FileNotFoundError as e:
             logger.info("Cannot access {}. However, it might be needed for"
@@ -605,6 +607,9 @@ carefully and if the changes are ok, click on the following link:
             logger.debug("No new entities to be inserted.")
         else:
             try:
+                logger.info(
+                    "Inserting {} Records...".format(
+                        len(missing_identifiables)))
                 guard.safe_insert(missing_identifiables, unique=False)
             except Exception as e:
                 DataModelProblems.evaluate_exception(e)

[Daniel Hornung]

I hope it is OK that I removed the if len(... part here.