Skip to content
Snippets Groups Projects

MAINT: be more specific with output

Merged MAINT: be more specific with output
f-output into dev
1 unresolved thread
Merged Henrik tom Wörden requested to merge f-output into dev
1 unresolved thread

Summary

Prevent the message that records are being inserted or updated when they are not. Now, each cfood prints how many records are inserted or updated if and only if some are changed or inserted.

Test Environment

Run the crawler in some environment.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/caosadvancedtools/crawler.py
605 607 logger.debug("No new entities to be inserted.")
606 608 else:
607 609 try:
610 logger.info(
  • Henrik tom Wörden marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Henrik tom Wörden merged

    merged

  • Henrik tom Wörden mentioned in commit 8fef480b

    mentioned in commit 8fef480b

    • Please register or sign in to reply