F json schema datamodel
Summary
For https://gitlab.indiscale.com/caosdb/customers/leibniz-zmt/management/-/issues/17 and https://gitlab.indiscale.com/caosdb/customers/leibniz-zmt/management/-/issues/24. A rudimentary parser of datamodels defined in json-schemas is introduced. It is sufficient to create flat datamodels, but it still lacks a lot.
- inheritance: This will probably require an extension of datamodel itself, so we won't implement it
- suggested properties: ditto
-
$defsand$refin json schema - Re-use of already defined RTs or Poroperties as List properties
- Reference properties that are different from the referenced RT. (Although this is possible for list of references)
- Values
- The
externkeyword from the yaml parser - Documentation
Focus
Mainly, a new parser has been introduced. Most changes are actually tests for the new parser.
Test Environment
In principle, the new unit tests and the new integration test are sufficient. You can also use Joscha's ZMT model to verify that the parser actually fulfills the minimal requirement of creating a datamodel for exactly this schema.
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related Issues -
Up-to-date CHANGELOG.md -
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there spezifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Merge request reports
Activity
assigned to @florian
requested review from @daniel
added 1 commit
- a252ccbf - FIX: Return correct entity in case of already
removed review request for @daniel
added 39 commits
-
5093428e...0b26273c - 29 commits from branch
dev - 87dd3224 - Revert "Revert "Merge branch 'f-extend-yaml-model' into 'dev'""
- 619c25e6 - Merge branch 'dev' into f-extend-yaml-model
- ff960e9c - TST: Add unit test for broken value parsing
- 483cc774 - STY: autopep'd
- fee161e5 - FIX: Correct parsing of dicts in properties
- a66f88ba - TST: Add test record to unittest for #72 (closed)
- 36e27fb0 - MAINT: Disable `role: File` for now in parser
- e41160a5 - MAINT: Refactor and simplify adding of properties
- 3b483d65 - DOC: Update integration test setup to new profile name
- dda6764d - Merge branch 'f-extend-yaml-model' into f-json-schema-datamodel
Toggle commit list-
5093428e...0b26273c - 29 commits from branch
added 2 commits
added 1 commit
- 41ec62d6 - TST: Extend enum test and add unittest for reference properties
added 1 commit
- de034a6e - ENH: Add "format": "date" for DATETIME properties
added 1 commit
- 042ae3c6 - WIP: Begin integration tests for json-schema datamodel parser
added 1 commit
- a94319fe - WIP: Add integration tests for references and enums
requested review from @timm
added 4 commits
-
1f0301ed...78c738ed - 3 commits from branch
dev - fee1f8f4 - Merge branch 'dev' into f-json-schema-datamodel
-
1f0301ed...78c738ed - 3 commits from branch
added 1 commit
- a323f4c0 - TST: add another test for json-schema parser
added 8 commits
-
a323f4c0...412fb71c - 7 commits from branch
dev - 00ec4ec8 - Merge branch 'dev' into f-json-schema-datamodel
-
a323f4c0...412fb71c - 7 commits from branch
mentioned in commit 69596c39