Skip to content
Snippets Groups Projects

F extend yaml model

F extend yaml model
f-extend-yaml-model into dev
1 unresolved thread
Merged Alexander Schlemmer requested to merge f-extend-yaml-model into dev
1 unresolved thread

Summary

See #68 (closed). Introduce a new keyword for yaml-models that allows insertion of Records and File objects.

In the course, setting (default) values of properties has been implemented and, more importantly, setting values of properties of records directly.

Note that this breaks one of the existing tests: values of properties can be different from dicts now.

Maybe related: #35

Focus

I added annotations in the commits.

Test Environment

There are new unit tests showing how to test the new keywords.

Check List for the Author

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alexander Schlemmer
  • Alexander Schlemmer
    Alexander Schlemmer @salexan started a thread on the diff
    • src/caosadvancedtools/models/parser.py
    177 184 ymlmodel["extern"] = []
    178 185
    179 186 for name in ymlmodel["extern"]:
    180 if db.execute_query("COUNT Property {}".format(name)) > 0:
    181 self.model[name] = db.execute_query(
    182 "FIND Property WITH name={}".format(name), unique=True)
    183
    184 elif db.execute_query("COUNT RecordType {}".format(name)) > 0:
    185 self.model[name] = db.execute_query(
    186 "FIND RecordType WITH name={}".format(name), unique=True)
    187 for role in ("Property", "RecordType", "Record", "File"):
  • Alexander Schlemmer
  • Alexander Schlemmer
  • Alexander Schlemmer
  • Alexander Schlemmer
  • Alexander Schlemmer marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Alexander Schlemmer marked the checklist item Reference related Issues as completed

    marked the checklist item Reference related Issues as completed

  • Florian Spreckelsen mentioned in issue #68 (closed)

    mentioned in issue #68 (closed)

  • Florian Spreckelsen changed the description

    changed the description

  • Florian Spreckelsen added 8 commits

    added 8 commits

    Compare with previous version

  • Florian Spreckelsen added 1 commit

    added 1 commit

    Compare with previous version

  • Florian Spreckelsen added 1 commit

    added 1 commit

    Compare with previous version

  • Florian Spreckelsen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Florian Spreckelsen marked the checklist item Up-to-date CHANGELOG.md as completed

    marked the checklist item Up-to-date CHANGELOG.md as completed

  • Florian Spreckelsen marked the checklist item The test environment setup works and the intended behavior is as completed

    marked the checklist item The test environment setup works and the intended behavior is as completed

  • Florian Spreckelsen marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Florian Spreckelsen marked the checklist item Check: Are there spezifications? Are they satisfied? as completed

    marked the checklist item Check: Are there spezifications? Are they satisfied? as completed

  • Florian Spreckelsen merged

    merged

  • Florian Spreckelsen mentioned in commit 751a0d04

    mentioned in commit 751a0d04

  • Timm Fitschen mentioned in merge request !31

    mentioned in merge request !31

    • Please register or sign in to reply