Skip to content
Snippets Groups Projects

MAINT: allow the apply_list_of_updates function to be used elsewhere

Merged Henrik tom Wörden requested to merge f-apply-updates into dev
All threads resolved!

Summary

This extracts the old push_identifiables_to_caosdb function from the crawler and allows other programms to use the logic.

Test Environment

Unit and integration tests

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Florian Spreckelsen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Florian Spreckelsen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Florian Spreckelsen marked the checklist item The test environment setup works and the intended behavior is as completed

    marked the checklist item The test environment setup works and the intended behavior is as completed

  • Florian Spreckelsen resolved all threads

    resolved all threads

  • requested review from @florian

  • Florian Spreckelsen resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • Florian Spreckelsen marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Florian Spreckelsen enabled an automatic merge when the pipeline for d4cae093 succeeds

    enabled an automatic merge when the pipeline for d4cae093 succeeds

  • Florian Spreckelsen aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • added 3 commits

    Compare with previous version

  • Florian Spreckelsen enabled an automatic merge when the pipeline for a83d8b3a succeeds

    enabled an automatic merge when the pipeline for a83d8b3a succeeds

  • mentioned in commit 7f3ccfb2

  • Please register or sign in to reply
    Loading