Skip to content

MAINT: enhance output when table cannot be parsed

Henrik tom Wörden requested to merge f-better-output into dev

Summary

Previously, when there was a problem with a table that shall be parsed by the crawler (e.g. wrong datatype, bad format of a date and so on) there was simply the statement: 'Cannot parse FILENAME'

Now the message that is contained in the ValueError is actually printed (not only in debugging logs).

Also, the check_datatypes method was missing an appropriate call to logging.warning.

Test Environment

Load a table using the webinterface where the table causes a ValueError in one of the converter functions.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Florian Spreckelsen

Merge request reports