FIX: Use openpyxl instead of xlrd

Fixes #29 (closed)

Summary

Removes the dependency on the discontinued xlrd<=1.2, uses xlrd>=2.0 for xls files and openpyxl for xlsx files.

Focus

Apparently we waited long enough so that Pandas fixed their engines for reading xls(x) files when both xlrd and openpyxl are installed. So only added a unittest for xls files and removed the version limitation

Test Environment

Simply do the unittests and the integrationtests with the updated xlrd version.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

• All automated tests pass
• Reference related Issues
• Up-to-date CHANGELOG.md
• Annotations in code (Gitlab comments)
  • Intent of new code
  • Problems with old code
  • Why this implementation?

Check List for the Reviewer

• I understand the intent of this MR
• All automated tests pass
• Up-to-date CHANGELOG.md
• The test environment setup works and the intended behavior is reproducible in the test environment
• In-code documentation and comments are up-to-date.
• Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

marked the checklist item Reference related Issues as completed

added 17 commits

• 92028c49...67edcd8a - 16 commits from branch dev
• e0e91208 - Merge branch 'dev' into f-openpyxl

Compare with previous version

added 3 commits

• bd15476c - MAINT: Remove depricated dependecy on xlrd 1.2
• 92d60ae8 - TST: Add unittest for .xls file
• c840dc90 - DOC: Update CHANGELOG

Compare with previous version

added 1 commit

• 16cf92c6 - TST: Add xls file for unit tests

Compare with previous version

changed the description

marked the checklist item Up-to-date CHANGELOG.md as completed

marked the checklist item All automated tests pass as completed

marked the checklist item Annotations in code (Gitlab comments) as completed

requested review from @henrik

added 1 commit

• 3c7177db - FIX: typo

Compare with previous version

resolved all threads

marked the checklist item I understand the intent of this MR as completed

marked the checklist item Up-to-date CHANGELOG.md as completed

marked the checklist item The test environment setup works and the intended behavior is as completed

marked the checklist item In-code documentation and comments are up-to-date. as completed

marked the checklist item Check: Are there spezifications? Are they satisfied? as completed

added 3 commits

• 3c7177db...8fef480b - 2 commits from branch dev
• 9213fee1 - Merge branch 'dev' into f-openpyxl

Compare with previous version

marked this merge request as ready