Skip to content
Snippets Groups Projects

FIX: Use openpyxl instead of xlrd

FIX: Use openpyxl instead of xlrd
f-openpyxl into dev
All threads resolved!
Merged Florian Spreckelsen requested to merge f-openpyxl into dev
All threads resolved!

Fixes #29 (closed)

Summary

Removes the dependency on the discontinued xlrd<=1.2, uses xlrd>=2.0 for xls files and openpyxl for xlsx files.

Focus

Apparently we waited long enough so that Pandas fixed their engines for reading xls(x) files when both xlrd and openpyxl are installed. So only added a unittest for xls files and removed the version limitation

Test Environment

Simply do the unittests and the integrationtests with the updated xlrd version.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Florian Spreckelsen
  • Florian Spreckelsen requested review from @henrik

    requested review from @henrik

  • Henrik tom Wörden added 1 commit

    added 1 commit

    Compare with previous version

  • Henrik tom Wörden resolved all threads

    resolved all threads

  • Henrik tom Wörden marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Henrik tom Wörden marked the checklist item Up-to-date CHANGELOG.md as completed

    marked the checklist item Up-to-date CHANGELOG.md as completed

  • Henrik tom Wörden marked the checklist item The test environment setup works and the intended behavior is as completed

    marked the checklist item The test environment setup works and the intended behavior is as completed

  • Henrik tom Wörden marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Henrik tom Wörden marked the checklist item Check: Are there spezifications? Are they satisfied? as completed

    marked the checklist item Check: Are there spezifications? Are they satisfied? as completed

  • Henrik tom Wörden added 3 commits

    added 3 commits

    Compare with previous version

  • Henrik tom Wörden marked this merge request as ready

    marked this merge request as ready

  • Henrik tom Wörden marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Henrik tom Wörden enabled an automatic merge when the pipeline for 9213fee1 succeeds

    enabled an automatic merge when the pipeline for 9213fee1 succeeds

  • Henrik tom Wörden aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • Henrik tom Wörden added 6 commits

    added 6 commits

    Compare with previous version

    Toggle commit list
  • Henrik tom Wörden added 1 commit

    added 1 commit

    Compare with previous version

  • Henrik tom Wörden merged

    merged

  • Henrik tom Wörden mentioned in commit 96c935ae

    mentioned in commit 96c935ae

    • Please register or sign in to reply