Skip to content
Snippets Groups Projects

f move test

Merged f move test
f-move-test into dev
3 unresolved threads
Merged Alexander Kreft requested to merge f-move-test into dev
3 unresolved threads

Summary

See #51 (closed) - The unittest test_data_model.py -> test_get_existing_entities was moved to integration tests because it needs to communicate with a server.

Focus

The test was copied and pasted

Test Environment

pytest

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Alexander Kreft

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
integrationtests/test_data_model.py
33 33 rt = db.execute_query("FIND RECORDTYPE TestRecord", unique=True)
34 34 assert rt.get_property("test") is not None
35 35
36 def tearDown(self):
37 try:
38 tests = db.execute_query("FIND test*")
39 tests.delete()
40 except Exception:
41 pass
42
  • Alexander Kreft
    Alexander Kreft @al-kr started a thread on the diff
    • unittests/test_data_model.py
    1 1 import unittest
    2 2
    3 3 import caosdb as db
    4 import pytest
  • Alexander Kreft
    Alexander Kreft @al-kr started a thread on the diff
    • unittests/test_data_model.py
    2 2
    3 3 import caosdb as db
    4 import pytest
    5 4 from caosadvancedtools.models.data_model import DataModel
    6 5
    7 6
    8 7 class DataModelTest(unittest.TestCase):
    9 8
    10 def tearDown(self):
    11 try:
    12 tests = db.execute_query("FIND test*")
    13 tests.delete()
    14 except Exception:
    15 pass
    16
    17 9 def test_collecting(self):
  • Henrik tom Wörden mentioned in commit 6f28bffe

    mentioned in commit 6f28bffe

  • Henrik tom Wörden merged

    merged

    • Please register or sign in to reply