Skip to content
Snippets Groups Projects

Automatic XLSX export

Merged I. Nüske requested to merge f-enh-143-automatic-xlsx-exporting into dev
All threads resolved!

Summary

Added a function to automatically export records from an Iterable to xlsx.
Addresses #143 (closed) / https://gitlab.indiscale.com/caosdb/customers/dimr/management/-/issues/269

Focus

Does this lack any features that are necessary and might have been missed during planning? Can this be used in the intended workflow?

Test Environment

Manual tests, ideally against test data I might not have available.
Additionally, if this needs to work on Windows and there is a working VM somewhere, this should probably also be tested there, as afaik NamedTemporaryFiles are somewhat error-prone on Win.

Check List for the Author

  • All automated tests pass
  • Reference related issues
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate developer documentation
  • Appropriate user documentation
  • Tests (or not necessary)
  • Annotations in code (Gitlab comments)

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?
Edited by Daniel Hornung

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I. Nüske added 1 commit

    added 1 commit

    Compare with previous version

  • I. Nüske changed the description

    changed the description

  • I. Nüske
  • I. Nüske
  • I. Nüske
  • I. Nüske
  • I. Nüske
  • I. Nüske
  • I. Nüske
  • I. Nüske
  • I. Nüske
  • I. Nüske
  • I. Nüske
  • I. Nüske marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • added 2 commits

    • 93fdae41 - TST: Add more XLSX tests, unignore validation parameter in convert_and_compare, fix typo
    • 64e51fa1 - Merge branch 'f-144-more-xlsx-tests' into 'f-enh-143-automatic-xlsx-exporting'

    Compare with previous version

  • added 4 commits

    • b1d0ec96 - MNT: Suppress high_level_api import warning
    • aec14b4a - STY: Ignore style issue
    • 0e9a9433 - Merge branch 'f-enh-143-automatic-xlsx-exporting' into f-146-make-highlevelapi-warning-filterable
    • 09ba1827 - Merge branch 'f-146-make-highlevelapi-warning-filterable' into 'f-enh-143-automatic-xlsx-exporting'

    Compare with previous version

  • I. Nüske requested review from @daniel

    requested review from @daniel

  • I. Nüske marked this merge request as ready

    marked this merge request as ready

  • I. Nüske added 2 commits

    added 2 commits

    • f48ae99c - TEST: Add minimal integration test
    • e21dfd7e - Merge remote-tracking branch 'origin/f-enh-143-automatic-xlsx-exporting' into...

    Compare with previous version

  • added 1 commit

    • f71dced3 - REFACTOR: Using new `plain_json` feature of high level api.

    Compare with previous version

  • Daniel Hornung added 5 commits

    added 5 commits

    • f71dced3...20f39511 - 2 commits from branch dev
    • cff4af34 - Merge remote-tracking branch 'origin/dev' into f-enh-143-automatic-xlsx-exporting
    • 9307d8fe - REFACTOR: Made validation_utils module private.
    • 86d82d52 - REFACTOR: Linting, PEPping, styling, docs.

    Compare with previous version

  • added 1 commit

    • b3d60be7 - REFACTOR: Linting, PEPping, styling, docs.

    Compare with previous version

  • Daniel Hornung resolved all threads

    resolved all threads

  • Daniel Hornung left review comments

    left review comments

  • Daniel Hornung approved this merge request

    approved this merge request

  • Daniel Hornung marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Daniel Hornung marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Daniel Hornung marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Daniel Hornung marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

  • Daniel Hornung marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

  • Daniel Hornung marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Daniel Hornung unapproved this merge request

    unapproved this merge request

  • Daniel Hornung left review comments

    left review comments

  • added 13 commits

    • b3d60be7...7b869cb1 - 3 earlier commits
    • a869af41 - TST: use clear_database from pylib
    • 177d8d2f - TEST: Try casting before comparison.
    • bdf50f31 - PERF: Using cache and new high-level API conversion.
    • 099eaf89 - REFACTOR: Simplified code and listened to deprecation warnings.
    • 701387f5 - REFACTOR: Even more simplifications.
    • 65108a52 - BUILD: Added profile.yaml for running integration tests.
    • b3ec716b - TEST: Actually running the integration test in the pipeline.
    • f0db1ea4 - TEST: Fixed problem with timezone information, added test.
    • f27e7707 - DOCS: Added fixme to fill_xlsx
    • 6ecde7c3 - Merge branch 'f-enh-143-xlsx-export-with-props' into 'f-enh-143-automatic-xlsx-exporting'

    Compare with previous version

  • added 12 commits

    • 6ecde7c3...9475350b - 2 earlier commits
    • 5c2eddff - WIP: Automatic list enum references.
    • 27089fb5 - WIP: Automatic list enum references.
    • a86cc51b - FIX: No over-eager enum detection.
    • 161ec447 - TEST: Added test data files.
    • 6663bbaa - STYLE: Linting.
    • de8de483 - FIX: More json schema export fixes.
    • 68470c42 - TEST: Cleanup of test data.
    • bf3da50a - BUILD: Increase minimum required version of pylib
    • d49d2709 - BUILD: Use correct minimal Pylib version
    • a01a74a3 - Merge branch 'f-enh-143-xlsx-export-lists' into 'f-enh-143-automatic-xlsx-exporting'

    Compare with previous version

  • added 1 commit

    • 8a4f18a7 - REFACTOR: Documentation and small changes.

    Compare with previous version

  • Daniel Hornung resolved all threads

    resolved all threads

  • Daniel Hornung approved this merge request

    approved this merge request

  • Daniel Hornung enabled an automatic merge when all merge checks for 8a4f18a7 pass

    enabled an automatic merge when all merge checks for 8a4f18a7 pass

  • Daniel Hornung mentioned in commit 043bbc46

    mentioned in commit 043bbc46

  • Please register or sign in to reply
    Loading