Skip to content

Parse binary or folmula boolean values

I. Nüske requested to merge f-parse-boolean-formulas into dev

Summary

Adresses https://gitlab.indiscale.com/caosdb/customers/dimr/management/-/issues/262.
In boolean fields, binary values and strings contianing true / false are now parsed to boolean.

Focus

  • Is there a possibility of this parsing method being too lax when parsing strings? Any possible usecase where an error would be useful that is not triggered anymore with this?

Test Environment

Saving a worksheet containing boolean values with LibreOffice triggers the error. If possible without extensive time investment, testing on a worksheet saved by Excel might be useful.

Check List for the Author

  • All automated tests pass
  • Reference related issues
  • Appropriate user and developer documentation (or not necessary)
  • Annotations in code (Gitlab comments)

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?
Edited by I. Nüske

Merge request reports

Loading