This fixes the first problem mentioned in #130 (moved) . The second one is going to be mended in caosdb-pylib!155 (merged) .
This fix essentially adds data types (and additional attributes) to properties that are part of record types. Otherwise comparisons of loaded data models with existing data models fail, because the lack of a data type is detected as a difference.
Please check:
There is a comprehensive unit test.
You can test whether it actually fixes the problem by:
parser.py
(caosdb-advanced-user-tools/src/caosadvancedtools/models/parser.py
)pytest unittests/test_yaml_model_parser.py -k test_comparison
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
For further good practices have a look at our review guidelines.