ENH: XLSX reader
Summary
XLSX reader has basic functionality now.
Still TODO:
- Early foreign column values checking (?)
- Result validation with schema
- Warnings: Additional or missing columns
Focus
- Does the conversion look good?
Test Environment
Run unit tests.
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
-
All automated tests pass -
Reference related issues caosdb/customers/dimr/management#220 -
Up-to-date CHANGELOG.md (or not necessary) -
Up-to-date JSON schema (or not necessary) -
Appropriate user and developer documentation (or not necessary) - How do I use the software? Assume "stupid" users.
- How do I develop or debug the software? Assume novice developers.
-
Annotations in code (Gitlab comments) - Intent of new code
- Problems with old code
- Why this implementation?
Check List for the Reviewer
-
I understand the intent of this MR -
All automated tests pass -
Up-to-date CHANGELOG.md (or not necessary) -
Appropriate user and developer documentation (or not necessary) -
The test environment setup works and the intended behavior is reproducible in the test environment -
In-code documentation and comments are up-to-date. -
Check: Are there specifications? Are they satisfied?
For further good practices have a look at our review guidelines.
Edited by Henrik tom Wörden
Merge request reports
Activity
assigned to @daniel
39 39 from copy import deepcopy 40 40 from enum import Enum 41 41 from types import SimpleNamespace 42 from typing import Dict, List, TextIO, Union 42 from typing import Any, TextIO, Union 43 43 44 44 from openpyxl import Workbook 45 45 from openpyxl.worksheet.worksheet import Worksheet 46 46 47 47 48 TRUTHY = {"true", "wahr", "x", "√", "yes", "ja", "y", "j"} # For multiple choice columns 49 FALSY = {"false", "falsch", "-", "no", "nein", "n"} # For multiple choice columns requested review from @henrik
Please register or sign in to reply