Skip to content
Snippets Groups Projects

ENH: XLSX reader

Merged ENH: XLSX reader
f-convert-xlsx-to-json into dev
1 unresolved thread
Merged Daniel Hornung requested to merge f-convert-xlsx-to-json into dev
1 unresolved thread

Summary

XLSX reader has basic functionality now.

Still TODO:

  • Early foreign column values checking (?)
  • Result validation with schema
  • Warnings: Additional or missing columns

Focus

  • Does the conversion look good?

Test Environment

Run unit tests.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related issues caosdb/customers/dimr/management#220
  • Up-to-date CHANGELOG.md (or not necessary)
  • Up-to-date JSON schema (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
    • How do I use the software? Assume "stupid" users.
    • How do I develop or debug the software? Assume novice developers.
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md (or not necessary)
  • Appropriate user and developer documentation (or not necessary)
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there specifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Henrik tom Wörden

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
    Daniel Hornung @daniel started a thread on the diff
    • src/caosadvancedtools/table_json_conversion/xlsx_utils.py
    39 39 from copy import deepcopy
    40 40 from enum import Enum
    41 41 from types import SimpleNamespace
    42 from typing import Dict, List, TextIO, Union
    42 from typing import Any, TextIO, Union
    43 43
    44 44 from openpyxl import Workbook
    45 45 from openpyxl.worksheet.worksheet import Worksheet
    46 46
    47 47
    48 TRUTHY = {"true", "wahr", "x", "√", "yes", "ja", "y", "j"} # For multiple choice columns
    49 FALSY = {"false", "falsch", "-", "no", "nein", "n"} # For multiple choice columns
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung
  • Daniel Hornung marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Daniel Hornung requested review from @henrik

    requested review from @henrik

  • Daniel Hornung added 1 commit

    added 1 commit

    • 4a507ac1 - MAINT: Increasing linting threshold.

    Compare with previous version

  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Daniel Hornung added 1 commit

    added 1 commit

    Compare with previous version

  • Henrik tom Wörden added 1 commit

    added 1 commit

    • 2d419b7f - DOC: update table-json-conversion doc

    Compare with previous version

  • Henrik tom Wörden marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Henrik tom Wörden marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Henrik tom Wörden marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

    marked the checklist item Up-to-date CHANGELOG.md (or not necessary) as completed

  • Henrik tom Wörden marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

    marked the checklist item Appropriate user and developer documentation (or not necessary) as completed

  • Henrik tom Wörden marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

    marked the checklist item The test environment setup works and the intended behavior is reproducible in the test as completed

  • Henrik tom Wörden marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Henrik tom Wörden marked the checklist item Check: Are there specifications? Are they satisfied? as completed

    marked the checklist item Check: Are there specifications? Are they satisfied? as completed

  • Henrik tom Wörden mentioned in commit b49aa866

    mentioned in commit b49aa866

  • Henrik tom Wörden merged

    merged

    • Please register or sign in to reply