Skip to content
Snippets Groups Projects

FIX CI

All threads resolved!
Merged Henrik tom Wörden requested to merge f-fix-ci into dev
All threads resolved!

Summary

There were multiple problems that lead to a pipeline crash. The main issue was that entities were multiple times in the exported xml file.

Test Environment

CI/unittest should be fine.

Check List for the Author

Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines

  • All automated tests pass
  • Reference related Issues
  • Up-to-date CHANGELOG.md
  • Annotations in code (Gitlab comments)
    • Intent of new code
    • Problems with old code
    • Why this implementation?

Check List for the Reviewer

  • I understand the intent of this MR
  • All automated tests pass
  • Up-to-date CHANGELOG.md
  • The test environment setup works and the intended behavior is reproducible in the test environment
  • In-code documentation and comments are up-to-date.
  • Check: Are there spezifications? Are they satisfied?

For further good practices have a look at our review guidelines.

Edited by Timm Fitschen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden
  • Henrik tom Wörden changed the description

    changed the description

  • Henrik tom Wörden marked the checklist item Up-to-date CHANGELOG.md as completed

    marked the checklist item Up-to-date CHANGELOG.md as completed

  • Henrik tom Wörden marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Henrik tom Wörden marked the checklist item Reference related Issues as completed

    marked the checklist item Reference related Issues as completed

  • Henrik tom Wörden marked the checklist item Annotations in code (Gitlab comments) as completed

    marked the checklist item Annotations in code (Gitlab comments) as completed

  • Henrik tom Wörden assigned to @timm and unassigned @henrik

    assigned to @timm and unassigned @henrik

  • Timm Fitschen added 1 commit

    added 1 commit

    Compare with previous version

  • Timm Fitschen resolved all threads

    resolved all threads

  • integration tests fail with

    Traceback (most recent call last):
      File "test_im_und_export.py", line 20, in <module>
        import_xml(os.path.join(directory.name, "caosdb_data.xml"), interactive=False)
      File "/home/tf/.local/lib/python/site-packages/caosadvancedtools/import_from_xml.py", line 97, in import_xml
        r = el.insert(unique=False)
      File "/home/tf/.local/lib/python/site-packages/caosdb/common/models.py", line 1078, in insert
        flags=flags)[0]
      File "/home/tf/.local/lib/python/site-packages/caosdb/common/models.py", line 3216, in insert
        raise_errors(self)
      File "/home/tf/.local/lib/python/site-packages/caosdb/common/models.py", line 4084, in raise_errors
        raise transaction_error
    caosdb.exceptions.TransactionError: TransactionError: One or more entities are not qualified. None of them have been inserted/updated/deleted.
        +--| REASONS |--
        |  -> FILE (id: -324, name: 'datafile.dat') CAUSED     |EntityError: This target path does already exist.
        +----------------
    
  • Timm Fitschen marked the checklist item I understand the intent of this MR as completed

    marked the checklist item I understand the intent of this MR as completed

  • Timm Fitschen marked the checklist item Up-to-date CHANGELOG.md as completed

    marked the checklist item Up-to-date CHANGELOG.md as completed

  • Timm Fitschen assigned to @henrik and unassigned @timm

    assigned to @henrik and unassigned @timm

  • Timm Fitschen assigned to @timm and unassigned @henrik

    assigned to @timm and unassigned @henrik

  • Timm Fitschen assigned to @henrik and unassigned @timm

    assigned to @henrik and unassigned @timm

  • Timm Fitschen requested review from @timm

    requested review from @timm

  • Timm Fitschen marked the checklist item All automated tests pass as completed

    marked the checklist item All automated tests pass as completed

  • Timm Fitschen marked the checklist item The test environment setup works and the intended behavior is as completed

    marked the checklist item The test environment setup works and the intended behavior is as completed

  • Timm Fitschen marked the checklist item Check: Are there spezifications? Are they satisfied? as completed

    marked the checklist item Check: Are there spezifications? Are they satisfied? as completed

  • Timm Fitschen marked the checklist item In-code documentation and comments are up-to-date. as completed

    marked the checklist item In-code documentation and comments are up-to-date. as completed

  • Timm Fitschen mentioned in commit de8b65bf

    mentioned in commit de8b65bf

  • merged

  • Please register or sign in to reply
    Loading