Skip to content
Snippets Groups Projects
Commit f533aa94 authored by Henrik tom Wörden's avatar Henrik tom Wörden
Browse files

MAINT: clarify difference between old and new behavior

parent 5b6cd1b0
No related branches found
No related tags found
2 merge requests!73MAINT: change wording of TableImporter argument and allow converters and...,!70ENH: allow to provide required columns explicitly
Pipeline #35531 passed
...@@ -11,8 +11,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ...@@ -11,8 +11,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed ### ### Changed ###
- The converters and datatype arguments of TableImporter now may have keys for nonexisting columns - The converters and datatype arguments of TableImporter now may have keys for nonexisting columns
- The obligatory key word no longer enforces that the columns exist. Since all rows are still
checked whether this column has a non-NULL value, this is deemed a non breaking change.
### Deprecated ### ### Deprecated ###
......
...@@ -221,7 +221,7 @@ class TableImporter(): ...@@ -221,7 +221,7 @@ class TableImporter():
value check is not necessary. value check is not necessary.
obligatory_columns : list, optional obligatory_columns : list, optional
List of column names that must not have missing values. List of column names that (if they exist) must not have missing values.
unique_keys : list, optional unique_keys : list, optional
List of column names that in combination must be unique: each row has a unique List of column names that in combination must be unique: each row has a unique
...@@ -387,6 +387,8 @@ class TableImporter(): ...@@ -387,6 +387,8 @@ class TableImporter():
while okay and i < len(self.obligatory_columns): while okay and i < len(self.obligatory_columns):
key = self.obligatory_columns[i] key = self.obligatory_columns[i]
if key not in df.columns:
continue
i += 1 i += 1
if pd.isnull(row.loc[key]): if pd.isnull(row.loc[key]):
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment