FIX: Don't cast float to int.

src/caosadvancedtools/table_importer.py

@@ -312,8 +312,8 @@ class TableImporter():
 
         .. note::
 
-          If columns are float, but should be integer or vice versa, this method converts the
-          respective columns in place.
+          If columns are integer, but should be float, this method converts the respective columns
+          in place.
 
         Parameters
         ----------
@@ -323,14 +323,13 @@ class TableImporter():
 
         """
         for key, datatype in self.datatypes.items():
-            # Check for castable numeric types first: We unconditionally cast float to int and vice
-            # versa, because CaosDB does not have different sizes anyway.
+            # Check for castable numeric types first: We unconditionally cast int to the default
+            # float, because CaosDB does not have different sizes anyway.
             col_dtype = df.dtypes[key]
             if not strict and not np.issubdtype(col_dtype, datatype):
                 issub = np.issubdtype
                 #  These special cases should be fine.
-                if ((issub(col_dtype, np.integer) and issub(datatype, np.floating))
-                        or (issub(col_dtype, np.floating) and issub(datatype, np.integer))):
+                if issub(col_dtype, np.integer) and issub(datatype, np.floating):
                     df[key] = df[key].astype(datatype)
 
             # Now check each element

unittests/test_table_importer.py

@@ -218,12 +218,10 @@ class XLSImporterTest(TableImporterTest):
                                    "float_as_float": float,
                                    "int_as_float": float,
                                    "int_as_int": int,
-                                   "float_as_int": int,
                                }
                                )
         df = importer.read_xls(os.path.join(os.path.dirname(__file__), "data", "datatypes.xlsx"))
         assert np.issubdtype(df.loc[0, "int_as_float"], float)
-        assert df.loc[1, "float_as_int"] == 6  # This is an acceptable rounding error.
 
 
 class CSVImporterTest(TableImporterTest):