Skip to content
Snippets Groups Projects
Commit 529aa5ca authored by Henrik tom Wörden's avatar Henrik tom Wörden
Browse files

MAINT: xfail a unittest; remove outdate TODO

parent df623eef
No related branches found
No related tags found
1 merge request!22Release 0.3
Pipeline #14439 passed with warnings
...@@ -64,6 +64,7 @@ class ConverterTest(unittest.TestCase): ...@@ -64,6 +64,7 @@ class ConverterTest(unittest.TestCase):
r"\this\computer,\this\computer"), r"\this\computer,\this\computer"),
["/this/computer", "/this/computer"]) ["/this/computer", "/this/computer"])
@pytest.mark.xfail(reason="To be fixed, see Issue #34")
def test_datetime(self): def test_datetime(self):
test_file = os.path.join(os.path.dirname(__file__), "date.xlsx") test_file = os.path.join(os.path.dirname(__file__), "date.xlsx")
self.importer = XLSImporter(converters={'d': datetime_converter, self.importer = XLSImporter(converters={'d': datetime_converter,
...@@ -167,6 +168,5 @@ class XLSImporterTest(unittest.TestCase): ...@@ -167,6 +168,5 @@ class XLSImporterTest(unittest.TestCase):
def test_raise(self): def test_raise(self):
tmp = NamedTemporaryFile(delete=False, suffix=".lol") tmp = NamedTemporaryFile(delete=False, suffix=".lol")
tmp.close() tmp.close()
# TODO ValueError is raised instead
self.assertRaises(DataInconsistencyError, self.importer.read_xls, self.assertRaises(DataInconsistencyError, self.importer.read_xls,
tmp.name) tmp.name)
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment