ENH: F remove value or property
All threads resolved!
All threads resolved!
Compare changes
Precondition for https://gitlab.indiscale.com/caosdb/customers/geomar/management/-/issues/110. Adds a function that removes a value from a property, and optionally, the property from the entity if it is empty afterwards. We used to implement this functionality in several customer-specific extensions, so I think it makes sense to have this upstream.
Check whether the behavior of the new function is reasonable also in the corner cases of list properties in which the value to be removed occurs more than once (i.e., remove "a"
from ["a", "b", "a"]
) and in case of an already empty property (remove "something"
from None
vs remove None
from None
).
Unit tests should be sufficient, but feel free to test it manually, too. Also check whether the docstring is understandable.
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
For further good practices have a look at our review guidelines.