I see one problem regarding the destructors: When a client uses caosdb_connection_connection_manager_get_default_connection to get the default connection, the destructor caosdb_connection_delete_connection should not be called, because the connection object is actually owned by the ConnectionManager. Maybe, we should prevent the deletion of the wrapped connection somehow, when the connection is owned by the ConnectionManager?
ConfigurationManager and ConnectionManager:
These two singletons are tightly coupled. When the ConfigurationManager is being reset, also the ConnectionManager resets. Is this a good behavior?
Please try and setup a client (e.g. the ccaosdbcli) with a json configuration file.
Check List for the Author
Please, prepare your MR for a review. Be sure to write a summary and a
focus and create gitlab comments for the reviewer. They should guide the
reviewer through the changes, explain your changes and also point out open
questions. For further good practices have a look at our review
guidelines
All automated tests pass
Reference related Issues
Up-to-date CHANGELOG.md
Annotations in code (Gitlab comments)
Intent of new code
Problems with old code
Why this implementation?
Check List for the Reviewer
I understand the intent of this MR
All automated tests pass
Up-to-date CHANGELOG.md
The test environment setup works and the intended behavior is
reproducible in the test environment
In-code documentation and comments are up-to-date.
Check: Are there spezifications? Are they satisfied?
