From 0c4a367b248e3c531f8bd1a0188504602a04948d Mon Sep 17 00:00:00 2001
From: Jose Manuel Serrano Amaut <a20122128@pucp.pe>
Date: Thu, 9 Mar 2023 18:35:52 -0500
Subject: [PATCH] [FEAT]: Refactor prop in VideoPreview from videoSource to
just src and allow that propto be a File or string
---
.../previews/VideoPreview/VideoPreview.tsx | 7 ++++++-
.../previews/VideoPreview/VideoPreviewProps.ts | 12 +++++-------
2 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/src/files-ui/components/previews/VideoPreview/VideoPreview.tsx b/src/files-ui/components/previews/VideoPreview/VideoPreview.tsx
index 63d7dfc..3cfe978 100644
--- a/src/files-ui/components/previews/VideoPreview/VideoPreview.tsx
+++ b/src/files-ui/components/previews/VideoPreview/VideoPreview.tsx
@@ -4,7 +4,12 @@ import { VideoPreviewProps } from "./VideoPreviewProps";
const VideoPreview: React.FC<VideoPreviewProps> = (
props: VideoPreviewProps
) => {
- const { videoSrc, /* autoPlay, controls, */style, className, ...others } = props;
+ const {
+ src: videoSrc,
+ /* autoPlay, controls, */ style,
+ className,
+ ...others
+ } = props;
const videoRef = React.useRef<HTMLVideoElement>(null);
diff --git a/src/files-ui/components/previews/VideoPreview/VideoPreviewProps.ts b/src/files-ui/components/previews/VideoPreview/VideoPreviewProps.ts
index 5f7ba75..95d7159 100644
--- a/src/files-ui/components/previews/VideoPreview/VideoPreviewProps.ts
+++ b/src/files-ui/components/previews/VideoPreview/VideoPreviewProps.ts
@@ -6,22 +6,20 @@ export interface VideoPreviewPropsMap extends OverridableComponentProps {
* video source in string format or File object
* FileItemComponent returns this value in onWatch handler
*/
- videoSrc?: File | string;
+ src?: File | string;
}
-type DefVideoProps = React.DetailedHTMLProps<React.VideoHTMLAttributes<HTMLVideoElement>, HTMLVideoElement>;
+type DefVideoProps = React.HTMLProps<HTMLVideoElement>;
+type VideoPropsOmitVideoPreviewPropsMap = Omit<DefVideoProps, keyof VideoPreviewPropsMap>;
-export type VideoPreviewProps =
+export type VideoPreviewProps = VideoPropsOmitVideoPreviewPropsMap &
{
[F in keyof VideoPreviewPropsMap]:
VideoPreviewPropsMap[F]
}
- &
- { [K in keyof DefVideoProps]:
- DefVideoProps[K]
- }
+
--
GitLab