From c0616635bc24752c1583d9e4642f23f51af6727c Mon Sep 17 00:00:00 2001
From: Timm Fitschen <t.fitschen@indiscale.com>
Date: Mon, 15 Feb 2021 13:09:32 +0100
Subject: [PATCH] TST: more tests for form_elements
---
src/core/js/form_elements.js | 6 +++---
test/core/js/modules/form_elements.js.js | 13 +++++++++++++
2 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/src/core/js/form_elements.js b/src/core/js/form_elements.js
index d0f960be..a4690932 100644
--- a/src/core/js/form_elements.js
+++ b/src/core/js/form_elements.js
@@ -1375,14 +1375,14 @@ var form_elements = new function () {
this.make_file_input = function (config) {
const ret = this._make_input(config);
$(ret)
- .find("input:file")
+ .find(":input")
.prop("multiple", !!config.multiple)
.css({
"display": "block"
});
if (config.accept) {
$(ret)
- .find("input:file")
+ .find(":input")
.attr("accept", config.accept);
}
@@ -1596,4 +1596,4 @@ var form_elements = new function () {
$(document).ready(function () {
caosdb_modules.register(form_elements);
-});
+});
\ No newline at end of file
diff --git a/test/core/js/modules/form_elements.js.js b/test/core/js/modules/form_elements.js.js
index d8e46fd2..aa2e281c 100644
--- a/test/core/js/modules/form_elements.js.js
+++ b/test/core/js/modules/form_elements.js.js
@@ -772,4 +772,17 @@ QUnit.test("select_input caching", async function (assert) {
form_elements.load_cached(cache, form[0]);
await sleep(200);
assert.equal(form_elements.get_cache_value(field[0]), "f", "value back to value from cache");
+});
+
+QUnit.test("make_file_input", function (assert) {
+ const config = {
+ name: "some_file",
+ multiple: true,
+ accept: ".tsv, .csv",
+ }
+ const file_input = $(form_elements.make_file_input(config));
+ assert.equal(file_input.find(":input").length, 1, "file input there");
+ assert.equal(file_input.find(":input").attr("name"), "some_file", "has file input with correct name");
+ assert.ok(file_input.find(":input").prop("multiple"), "is multiple");
+ assert.equal(file_input.find(":input").attr("accept"), ".tsv, .csv", "accept there");
});
\ No newline at end of file
--
GitLab