From a09314a13da6426e03403edc6b6399390045b043 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Henrik=20tom=20W=C3=B6rden?= <h.tomwoerden@indiscale.com>
Date: Thu, 10 Dec 2020 17:23:52 +0100
Subject: [PATCH] doc
---
unittests/test_authentication_plain.py | 6 ++++++
unittests/test_connection.py | 4 ++++
2 files changed, 10 insertions(+)
diff --git a/unittests/test_authentication_plain.py b/unittests/test_authentication_plain.py
index 1b7cbf0c..8548749a 100644
--- a/unittests/test_authentication_plain.py
+++ b/unittests/test_authentication_plain.py
@@ -33,6 +33,12 @@ from pytest import raises
def test_subclass_configure():
+ # TODO I do not see the meaning of this test.
+ #It only tests, that the call of the super version of configure sets the
+ #password property. And that due to the subclassing no longer a password
+ # argument can be provided.
+ # Suggestion: Either remove this test or state in what context this test
+ # is meanigful.
"""Test the correct passing of the password argument."""
class SubClassOf(PlainTextCredentialsProvider):
"""A simple subclass of PlainTextCredentialsProvider."""
diff --git a/unittests/test_connection.py b/unittests/test_connection.py
index 60f1b735..1dfd1fce 100644
--- a/unittests/test_connection.py
+++ b/unittests/test_connection.py
@@ -157,6 +157,7 @@ def test_init_response():
response = MockUpResponse(
status=200, headers={"sessionToken": "SessionToken"}, body="Body")
there(response)
+
return response
@@ -180,6 +181,7 @@ def test_getter_session_token():
def test_init_connection():
connection = MockUpServerConnection()
there(connection)
+
return connection
@@ -189,6 +191,7 @@ def test_resources_list():
assert len(connection.resources) == 1
connection.resources.append(lambda **kwargs: test_init_response())
assert len(connection.resources) == 2
+
return connection
@@ -219,6 +222,7 @@ def setup_two_resources():
connection = test_init_connection()
connection.resources.extend([r1, r2, r3])
+
return connection
--
GitLab