From 7d5de73a3e8794a82579dcdfbaf6f3729efc8003 Mon Sep 17 00:00:00 2001
From: Joscha Schmiedt <joscha@schmiedt.dev>
Date: Thu, 4 Apr 2024 23:01:01 +0200
Subject: [PATCH] WIP: Fix more mypy errors in models.py
---
src/linkahead/common/models.py | 24 +++++++++++-------------
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/src/linkahead/common/models.py b/src/linkahead/common/models.py
index 16243a06..bfaf8f83 100644
--- a/src/linkahead/common/models.py
+++ b/src/linkahead/common/models.py
@@ -558,24 +558,22 @@ class Entity:
"""
- prop = self.get_property(property_name)
- if prop is None:
+ property = self.get_property(property_name)
+ if property is None:
return self
-
- property_value = prop.value
-
- if property_value is None:
+
+ if property.value is None:
remove_if_empty_afterwards = False
empty_afterwards = False
- if isinstance(property_value, list):
- if value in property_value:
- property_value.remove(value)
- if property_value == []:
- property_value = None
+ if isinstance(property.value, list):
+ if value in property.value:
+ property.value.remove(value)
+ if property.value == []:
+ property.value = None
empty_afterwards = True
- elif property_value == value:
- property_value = None
+ elif property.value == value:
+ property.value = None
empty_afterwards = True
if remove_if_empty_afterwards and empty_afterwards:
--
GitLab