From 3bf862b923d3830e939feb93fd6e244953d7b4e0 Mon Sep 17 00:00:00 2001 From: Daniel <daniel@harvey> Date: Wed, 6 May 2020 15:55:02 +0200 Subject: [PATCH] DOC: Gitlab merge template. --- .gitlab/merge_request_templates/General.md | 29 ++++++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644 .gitlab/merge_request_templates/General.md diff --git a/.gitlab/merge_request_templates/General.md b/.gitlab/merge_request_templates/General.md new file mode 100644 index 00000000..b3934b37 --- /dev/null +++ b/.gitlab/merge_request_templates/General.md @@ -0,0 +1,29 @@ +Insert a meaningful description for this merge request here. What is the +new/changed behavior? Which bug was fixed? + +--- + +Add the text above this line to the git comment. + +# Check list for the author # + +- [ ] All tests pass. (style, unit/integration, static code analysis) +- [ ] What is the main focus for the reviewer? What is the core intent of this + MR? +- [ ] How to set up a test environment. +- [ ] Annotations in code (Gitlab comments) + - Intent of new code + - Problems with old code + - Why this implementation? + +# Check list for the reviewer # + +- [ ] Tests pass +- [ ] Do I understand the intent of this MR? +- [ ] Does the test environment setup work? +- [ ] Is the intended behavior reproducible in the test environment? +- [ ] Code overview: Which functions/classes are relevant for understanding the MR? +- [ ] Work through the open comment threads. +- [ ] Are the doc strings / comments up-to-date? Or have there been behavioral + changes without amending the documentation? +- [ ] Are there spezifications? Are they satisfied? -- GitLab