From 3029b906106af7131c6854f10ab2dbc09a8c90a4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Henrik=20tom=20W=C3=B6rden?= <h.tomwoerden@indiscale.com>
Date: Tue, 5 Nov 2024 22:20:29 +0100
Subject: [PATCH] FIX: keep old behavior
---
src/linkahead/apiutils.py | 6 ++----
unittests/test_apiutils.py | 2 +-
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/linkahead/apiutils.py b/src/linkahead/apiutils.py
index fd937215..d51171c7 100644
--- a/src/linkahead/apiutils.py
+++ b/src/linkahead/apiutils.py
@@ -316,10 +316,8 @@ def compare_entities(entity0: Optional[Entity] = None,
# add to diff if attr has different values or is not set for one entity
if (attr0_unset != attr1_unset) or (attr0 != attr1):
- if not attr0_unset:
- diff[0][attr] = attr0
- if not attr1_unset:
- diff[1][attr] = attr1
+ diff[0][attr] = attr0
+ diff[1][attr] = attr1
# compare value
ent0_val, ent1_val = entity0.value, entity1.value
diff --git a/unittests/test_apiutils.py b/unittests/test_apiutils.py
index 5c9bc920..cdca1280 100644
--- a/unittests/test_apiutils.py
+++ b/unittests/test_apiutils.py
@@ -141,7 +141,7 @@ def test_compare_entities():
assert "datatype" in diff_r1["properties"]
assert "datatype" in diff_r1["properties"]["datatype"]
assert "datatype" in diff_r2["properties"]
- assert "datatype" not in diff_r2["properties"]["datatype"]
+ assert "datatype" in diff_r2["properties"]["datatype"]
# test compare units of properties
r1 = db.Record()
--
GitLab