From b755c81da5091a1669c2bf20d736dcc628aa64a0 Mon Sep 17 00:00:00 2001
From: Timm Fitschen <t.fitschen@indiscale.com>
Date: Tue, 31 Aug 2021 15:55:20 +0200
Subject: [PATCH] MAINT: clean up comments in test_issues_server.py

---
 tests/test_issues_server.py | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/tests/test_issues_server.py b/tests/test_issues_server.py
index 669c3b1..22b2508 100644
--- a/tests/test_issues_server.py
+++ b/tests/test_issues_server.py
@@ -263,14 +263,14 @@ def test_issue_170():
     """update scalar data type to list data type"""
     p = db.Property(name="TestProp1", datatype=db.LIST(db.INTEGER))
     p.value = [1, 2]
-    p.insert()  # works
+    p.insert()
 
     p2 = db.execute_query("FIND TestProp1", unique=True)
     assert p2.datatype == db.LIST(db.INTEGER)
     assert p2.value == [1, 2]
 
     p.description = "TestDescription"
-    p.update()  # fails
+    p.update()  # this failed
 
     p2 = db.execute_query("FIND TestProp1", unique=True)
     assert p2.datatype == db.LIST(db.INTEGER)
@@ -278,23 +278,26 @@ def test_issue_170():
     assert p2.description == "TestDescription"
 
     p = db.Property(name="TestProp2", datatype=db.DOUBLE)
-    p.insert()  # works
+    p.insert()
 
     p.datatype = db.LIST(db.INTEGER)
-    p.update()  # works
-    p2 = db.execute_query("FIND TestProp1", unique=True)
+    p.update()  # this worked because no value yet
+    p2 = db.execute_query("FIND TestProp2", unique=True)
+    assert p2.datatype == db.LIST(db.INTEGER)
+    p.value = [1, 2]
+
+    p.update()  # this failed
+    p2 = db.execute_query("FIND TestProp2", unique=True)
     assert p2.datatype == db.LIST(db.INTEGER)
     assert p2.value == [1, 2]
-    p2.value = [1, 2]
-    p2.update()  # fails
 
     p = db.Property(name="TestProp3", datatype=db.DOUBLE)
-    p.insert()  # works
+    p.insert()
 
     p.datatype = db.LIST(db.INTEGER)
     p.value = [1, 2]
-    p.update()  # fails
+    p.update()  # this failed
 
-    p2 = db.execute_query("FIND TestProp1", unique=True)
+    p2 = db.execute_query("FIND TestProp3", unique=True)
     assert p2.datatype == db.LIST(db.INTEGER)
     assert p2.value == [1, 2]
-- 
GitLab