From b62ee8a3bdaa5bcdadaf9fb93537ca153d91fc92 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Henrik=20tom=20W=C3=B6rden?= <henrik@trineo.org>
Date: Tue, 31 Dec 2019 11:13:11 +0100
Subject: [PATCH] MAINT: added comments

---
 tests/test_file.py | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/tests/test_file.py b/tests/test_file.py
index b8f36f6..0f5b33e 100644
--- a/tests/test_file.py
+++ b/tests/test_file.py
@@ -354,6 +354,9 @@ def test_consistency_file_was_modified():
         assert_equal(c.messages["Info", 0][0], "File system is consistent.")
 
         # run consistency check with modified warning)
+        # TODO fix
+        # This smells badly. The argument is meant to transport the location
+        # that is checked. Understanding of the code is difficult.
         c = runCheck(None, "-c FILE_WAS_MODIFIED")
         assert_is_not_none(c.messages["Error", 0])
         assert_equal(
@@ -412,6 +415,9 @@ def test_consistency_file_does_not_exist():
         assert_equal(c.messages["Info", 0][0],
                      "File system below debug/ is consistent.")
 
+        # TODO fix
+        # This smells badly. The argument is meant to transport the location
+        # that is checked. Understanding of the code is difficult.
         c = runCheck(None, "-c FILE_DOES_NOT_EXIST")
         assert_is_not_none(c.messages["Error", 0])
         assert_equal(
@@ -452,6 +458,9 @@ def test_consistency_unknown_file():
     assert_is_not_none(c.messages["Info", 0])
     assert_equal(c.messages["Info", 0][0], "File system is consistent.")
 
+    # TODO fix
+    # This smells badly. The argument is meant to transport the location
+    # that is checked. Understanding of the code is difficult.
     c = runCheck(None, "-c UNKNOWN_FILE")
     assert_is_not_none(c.messages["Warning", 0])
     assert_equal(c.messages["Warning", 0][0], 'debug/: Unknown file.')
-- 
GitLab