From 4b0f2f6f46b6f1f11f95653fd7e67cf8891b6753 Mon Sep 17 00:00:00 2001
From: Timm Fitschen <t.fitschen@indiscale.com>
Date: Mon, 9 Aug 2021 20:17:06 +0200
Subject: [PATCH] WIP: files

---
 proto/caosdb/entity/v1alpha1/main.proto | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/proto/caosdb/entity/v1alpha1/main.proto b/proto/caosdb/entity/v1alpha1/main.proto
index ae5772d..c06a0a6 100644
--- a/proto/caosdb/entity/v1alpha1/main.proto
+++ b/proto/caosdb/entity/v1alpha1/main.proto
@@ -501,8 +501,8 @@ message RetrieveRequest {
   // Is the client requesting to download the file associated with the
   // retrieved entity or query results?
   bool register_file_download = 3;
-  // Settings for the download. Ignored if register_file_download is false.
-  FileTransmissionSettings download_settings = 4;
+  //TODO Settings for the download. Ignored if register_file_download is false.
+  //FileTransmissionSettings download_settings = 4;
 }
 
 // Response to a retrieve request
@@ -518,8 +518,6 @@ message RetrieveResponse {
     // Result of a COUNT query
     int64 count_result = 4;
   }
-  // Response to `register_file_download = true` in the RetrieveRequest.
-  string registration_id = 5;
 }
 
 // Single delete request (by id)
@@ -739,7 +737,7 @@ service FileTransmissionService {
   rpc RegisterFileUpload(RegisterFileUploadRequest)
       returns (RegisterFileUploadResponse);
   // The actual file upload. The upload has to be registered prior to this rpc.
-  rpc FileUpload(FileUploadRequest) returns (FileUploadResponse);
+  rpc FileUpload(stream FileUploadRequest) returns (FileUploadResponse);
   // A file download. The download has to be registered prior this rpc in the
   // RetrieveRequest.
   rpc FileDownload(FileDownloadRequest) returns (FileDownloadResponse);
-- 
GitLab