From d3e673d7393761dcec34b947e151e92a91d8db0c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Henrik=20tom=20W=C3=B6rden?= <h.tomwoerden@indiscale.com>
Date: Tue, 28 Dec 2021 18:56:27 +0100
Subject: [PATCH] WIP
---
src/newcrawler/identifiable_adapters.py | 25 +++----------------------
1 file changed, 3 insertions(+), 22 deletions(-)
diff --git a/src/newcrawler/identifiable_adapters.py b/src/newcrawler/identifiable_adapters.py
index 5bddc64c..ff40a11f 100644
--- a/src/newcrawler/identifiable_adapters.py
+++ b/src/newcrawler/identifiable_adapters.py
@@ -121,10 +121,6 @@ class IdentifiableAdapter(object):
"""
pass
- @abstractmethod
- def resolve_reference(self, record: db.Record):
- pass
-
def get_identifiable(self, record: db.Record):
"""
retrieve the registred identifiable and fill the property values to create an
@@ -223,8 +219,9 @@ class LocalStorageIdentifiableAdapter(IdentifiableAdapter):
with open(filename, "r") as f:
self._records = db.Container().from_xml(f.read())
- # TODO: move to super class?
- def is_identifiable_for_record(self, registered_identifiable: db.RecordType, record: db.Record):
+ def is_identifiable_for_record(self,
+ registered_identifiable: db.RecordType,
+ record: db.Record):
"""
Check whether this registered_identifiable is an identifiable for the record.
@@ -301,22 +298,6 @@ class LocalStorageIdentifiableAdapter(IdentifiableAdapter):
return None
return candidates[0]
- def resolve_reference(self, value: db.Record):
- if self.get_registered_identifiable(value) is None:
- raise NotImplementedError("Non-identifiable references cannot"
- " be used as properties in identifiables.")
- # TODO: just resolve the entity
-
- value_identifiable = self.retrieve_identified_record(value)
- if value_identifiable is None:
- raise RuntimeError("The identifiable which is used as property"
- " here has to be inserted first.")
-
- if value_identifiable.id is None:
- raise RuntimeError("The entity has not been assigned an ID.")
-
- return value_identifiable.id
-
class CaosDBIdentifiableAdapter(IdentifiableAdapter):
"""
--
GitLab