diff --git a/src/newcrawler/identifiable_adapters.py b/src/newcrawler/identifiable_adapters.py index be725993da4b0300c8092148c980d150d6da0ee5..66cdb67c71ab61cfabe4359079e648f79b1fb6f8 100644 --- a/src/newcrawler/identifiable_adapters.py +++ b/src/newcrawler/identifiable_adapters.py @@ -364,7 +364,7 @@ class LocalStorageIdentifiableAdapter(IdentifiableAdapter): " be used as properties in identifiables.") # TODO: just resolve the entity - value_identifiable = self.retrieve_identified_record(value) + value_identifiable = self.retrieve_identified_record_for_record(value) if value_identifiable is None: raise RuntimeError("The identifiable which is used as property" " here has to be inserted first.") diff --git a/unittests/test_tool.py b/unittests/test_tool.py index a3ebfbd09ac9ce55b53b4f2508f3cc037490a542..ac57a8f32be649f47e8038a37f9edfc35df58605 100755 --- a/unittests/test_tool.py +++ b/unittests/test_tool.py @@ -297,6 +297,10 @@ def test_remove_unnecessary_updates(): assert len(upl) == 1 +# Current status: +# TODO: currently, this test fails, because non identifiable records cannot +# be inserted into the cache. Solution might be, just not to add them +# into the local cache. Probably in split_into_inserts_and_updates. @pytest.mark.xfail def test_identifiable_adapter_no_identifiable(crawler, ident): del ident._registered_identifiables["Person"]