From ab41e29c26b502884356ee945342eeb7acd4de7a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Henrik=20tom=20W=C3=B6rden?= <h.tomwoerden@indiscale.com>
Date: Tue, 27 Sep 2022 11:31:36 +0200
Subject: [PATCH] ENH: allow null values in dicts

---
 src/caoscrawler/converters.py                          | 2 ++
 unittests/test_directories/examples_json/testjson.json | 1 +
 2 files changed, 3 insertions(+)

diff --git a/src/caoscrawler/converters.py b/src/caoscrawler/converters.py
index 5c193e61..3fbf9939 100644
--- a/src/caoscrawler/converters.py
+++ b/src/caoscrawler/converters.py
@@ -513,6 +513,8 @@ class DictConverter(Converter):
                 children.append(DictBooleanElement(name, value))
             elif type(value) == float:
                 children.append(DictFloatElement(name, value))
+            elif type(value) == type(None):
+                continue
             else:
                 children.append(DictElement(name, value))
                 warnings.warn(f"The value in the dict for key:{name} has an unknown type. "
diff --git a/unittests/test_directories/examples_json/testjson.json b/unittests/test_directories/examples_json/testjson.json
index b893b608..d37ea2de 100644
--- a/unittests/test_directories/examples_json/testjson.json
+++ b/unittests/test_directories/examples_json/testjson.json
@@ -6,6 +6,7 @@
         {
 		    "firstname": "Miri",
 		    "lastname": "Mueller",
+		    "other": null,
 		    "email": "miri.mueller@science.de"
 	    },
         {
-- 
GitLab