From 8834d29f3689e3e557fe813e76be8e3ad599a36a Mon Sep 17 00:00:00 2001
From: Alexander Schlemmer <alexander.schlemmer@ds.mpg.de>
Date: Wed, 15 Mar 2023 14:30:47 +0100
Subject: [PATCH] REVIEW Reintroduced two deprecated arguments for the crawler
class
---
src/caoscrawler/crawl.py | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/src/caoscrawler/crawl.py b/src/caoscrawler/crawl.py
index 3376f7ff..eee0046c 100644
--- a/src/caoscrawler/crawl.py
+++ b/src/caoscrawler/crawl.py
@@ -178,11 +178,18 @@ class Crawler(object):
"""
def __init__(self,
+ generalStore: Optional[GeneralStore] = None,
+ debug: bool = False,
identifiableAdapter: Optional[IdentifiableAdapter] = None,
securityMode: SecurityMode = SecurityMode.UPDATE):
"""
Create a new crawler and initialize an empty RecordStore and GeneralStore.
+ Deprecated arguments:
+ - The debug argument does not have an effect anymore.
+ - generalStore: This argument does not have an effect anymore. It might be added to the scanning
+ functions in the scanner module in the future, if needed.
+
Parameters
----------
identifiableAdapter : IdentifiableAdapter
@@ -203,6 +210,16 @@ class Crawler(object):
if identifiableAdapter is not None:
self.identifiableAdapter = identifiableAdapter
+ if not debug:
+ # TODO: not ideal, how to warn if debug is explicitely set to false?
+ warnings.warn(DeprecationWarning(
+ "The debug argument of the Crawler class is deprecated and has no effect."))
+
+ if generalStore is not None:
+ warnings.warn(DeprecationWarning(
+ "The generalStore argument of the Crawler class is deprecated and has no effect."))
+
+
def generate_run_id(self):
self.run_id = uuid.uuid1()
--
GitLab