diff --git a/src/caoscrawler/converters.py b/src/caoscrawler/converters.py index d28d1d53819ba8fe400bcfe036703bb5686bc47f..baf8a366a8d16a29933a781d1d8bd70c295e1061 100644 --- a/src/caoscrawler/converters.py +++ b/src/caoscrawler/converters.py @@ -468,6 +468,7 @@ class Converter(object, metaclass=ABCMeta): def create_records(self, values: GeneralStore, records: RecordStore, element: StructureElement): # TODO why is element passed but not used??? + # ANSWER: because it might be used by overriding child classes. if "records" not in self.definition: return [] diff --git a/src/caoscrawler/scanner.py b/src/caoscrawler/scanner.py index f6fc4d8f81d68277d6ad405ab04f50999d85525d..fe8a6dbfdd7de93c84e8cabd28a9c0dae8b8468a 100644 --- a/src/caoscrawler/scanner.py +++ b/src/caoscrawler/scanner.py @@ -362,6 +362,8 @@ def scanner(items: list[StructureElement], debug_tree.debug_metadata["usage"][str(element)].add( "/".join(converters_path + [converter.name])) mod_info = debug_tree.debug_metadata["provenance"] + # TODO: actually keys_modified must not be None. create_records should + # always return a list. if keys_modified is not None: for record_name, prop_name in keys_modified: # TODO: check