diff --git a/src/caoscrawler/converters.py b/src/caoscrawler/converters.py index 9999fa5342d5803c7b0335e75b1473dcb86cd68a..000d5394af127468b41807369c2030475c35e389 100644 --- a/src/caoscrawler/converters.py +++ b/src/caoscrawler/converters.py @@ -816,7 +816,8 @@ class HeuristicDictConverter(DictElementConverter): property values from the dictionary keys. """ - def _validate_definition(definition: dict, name: str): + + def _validate_definition(self, definition: dict, name: str): if "record_from_dict" not in definition or definition["record_from_dict"] is None: @@ -843,15 +844,11 @@ class HeuristicDictConverter(DictElementConverter): def _create_or_return_record(rec_name: str, parent_names: Optional[Union[str, List[str]]] = None): - if parent_names is None: parent_names = [rec_name] elif not isinstance(parent_names, list): parent_names = [parent_names] - - - keys_modified.extend(super().create_records( values=values, records=records, element=element)) diff --git a/unittests/test_converters.py b/unittests/test_converters.py index eb7b8c6b367ea27ba2f68e02f9c7de4028e21a61..8fa44b8ae0b5af13803725ceca9755ad514d0861 100644 --- a/unittests/test_converters.py +++ b/unittests/test_converters.py @@ -72,6 +72,10 @@ def converter_registry(): "DictElement": { "converter": "DictElementConverter", "package": "caoscrawler.converters"}, + "HeuristicDictElement": { + "converter": "HeuristicDictConverter", + "package": "caoscrawler.converters" + }, "TextElement": { "converter": "TextElementConverter", "package": "caoscrawler.converters"},