diff --git a/src/caoscrawler/converters/converters.py b/src/caoscrawler/converters/converters.py index 5fcdfda69970b73fc85782bfd78943577b379c39..e16b2c0fbaeeee419b0e3f235339dc18cd4da885 100644 --- a/src/caoscrawler/converters/converters.py +++ b/src/caoscrawler/converters/converters.py @@ -1295,17 +1295,17 @@ class YAMLFileConverter(SimpleFileConverter): def match_name_and_value(definition, name, value): """Take match definitions from the definition argument and apply regular expression to name and - possibly value + possibly value. - one of the keys 'match_name' and "match' needs to be available in definition - 'match_value' is optional + Exactly one of the keys ``match_name`` and ``match`` must exist in ``definition``, + ``match_value`` is optional Returns ------- out: None, if match_name or match lead to no match. Otherwise, returns a dictionary with the - matched groups, possibly including matches from using match_value + matched groups, possibly including matches from using `definition["match_value"]` """ if "match_name" in definition: diff --git a/unittests/test_issues.py b/unittests/test_issues.py index b7cde0168738eb4546d87e688d4056323951fa41..779f77711fe18df2433f03580e7e3e4f2035f0f4 100644 --- a/unittests/test_issues.py +++ b/unittests/test_issues.py @@ -218,8 +218,8 @@ def test_issue_112(converter_registry): if rec.name == "event_a": assert rec.get_property("event_time") is not None assert rec.get_property("event_time").value == "2025-02-06" - elif rec.name == "event_b": - # This should not have matched + if rec.name == "event_b": + # `date` field is empty, so there must be no match assert rec.get_property("event_time") is None if rec.name == "event_c": assert rec.get_property("event_time") is not None