Florian Spreckelsen (7e7eeddc) at 28 Mar 11:59
TST: Extend unit test by errors and callables
... and 2 more commits
extern: https://gitlab.com/linkahead/linkahead-crawler/-/issues/88
Florian Spreckelsen (6c5efb5c) at 27 Mar 13:26
For #127. This just improves the original error message and does not introduce additional error handling.
Since it was highly non-trivial to introduce error handling that could actually distinguish between (cf. docstring of new test) not being able to merge b1
and b2
because of unresolvable merge conflicts in c1
and c2
and only having to postpone the merge because of apparent merge conflicts that will be resolved down the line, we do not introduce new error handling. Instead, we point out that the error with missing referencing identifiables might be due to merge conflicts in the referencing entities.
Unit test
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
For further good practices have a look at our review guidelines.
Florian Spreckelsen (24686e48) at 27 Mar 13:26
Merge branch 'f-fix-misleading-error' into 'dev'
... and 3 more commits
The docstring was incomplete...
Should always have been a RuntimeError. There is nothing to be implemented here.
For #127. This just improves the original error message and does not introduce additional error handling.
Since it was highly non-trivial to introduce error handling that could actually distinguish between (cf. docstring of new test) not being able to merge b1
and b2
because of unresolvable merge conflicts in c1
and c2
and only having to postpone the merge because of apparent merge conflicts that will be resolved down the line, we do not introduce new error handling. Instead, we point out that the error with missing referencing identifiables might be due to merge conflicts in the referencing entities.
Unit test
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
For further good practices have a look at our review guidelines.
Florian Spreckelsen (6c5efb5c) at 26 Mar 12:53
TST: Test for correct error type
... and 3 more commits
Florian Spreckelsen (1842ef89) at 26 Mar 10:16
WIP: Add helper functions
Alexander Schlemmer (0bec5c0c) at 25 Mar 14:43
FIX: typo in passing the argument to scan_directory
... and 2 more commits
Part of https://gitlab.indiscale.com/caosdb/customers/3dmmto/management/-/issues/30. Introduce a converter that adds from dictionary keys to a given record.
Point the reviewer to the core of the code change. Where should they start reading? What should they focus on (e.g. security, performance, maintainability, user-friendliness, compliance with the specs, finding more corner cases, concrete questions)?
How to set up a test environment for manual testing?
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
For further good practices have a look at our review guidelines.
Florian Spreckelsen (963d2f53) at 25 Mar 11:50
WIP: Move to separate converter
Florian Spreckelsen (b44cad88) at 25 Mar 09:26
WIP: Begin create_records function
... and 24 more commits
In a fresh venv, after installing "pip install -e caosdb-crawler", I get the following error when starting the "caosdb-crawler":
Traceback (most recent call last):
File "(...)/venv/bin/caosdb-crawler", line 5, in <module>
from caoscrawler.crawl import main
File "(...)/src/caoscrawler/__init__.py", line 1, in <module>
from .crawl import Crawler, SecurityMode
File "(...)/src/caoscrawler/crawl.py", line 62, in <module>
from .debug_tree import DebugTree
File "(...)/src/caoscrawler/debug_tree.py", line 61, in <module>
from .version import check_cfood_version
File "(...)/src/caoscrawler/version.py", line 25, in <module>
from packaging.version import parse as parse_version
ModuleNotFoundError: No module named 'packaging'
Seems like packaging is missing as a dependency.
Florian Spreckelsen (2d48821c) at 21 Mar 16:30
Merge branch 'release-v0.7.1' into 'main'
Florian Spreckelsen (21b8e5e9) at 21 Mar 16:29
Florian Spreckelsen (2d48821c) at 21 Mar 16:28
Merge branch 'release-v0.7.1' into 'main'
... and 34 more commits
After #129. Insert a meaningful description for this merge request here: What is the new/changed behavior? Which bug has been fixed? Are there related issues?
Point the reviewer to the core of the code change. Where should they start reading? What should they focus on (e.g. security, performance, maintainability, user-friendliness, compliance with the specs, finding more corner cases, concrete questions)?
How to set up a test environment for manual testing?
Please, prepare your MR for a review. Be sure to write a summary and a focus and create gitlab comments for the reviewer. They should guide the reviewer through the changes, explain your changes and also point out open questions. For further good practices have a look at our review guidelines
For further good practices have a look at our review guidelines.