diff --git a/include/caosdb/file_transmission/file_reader.h b/include/caosdb/file_transmission/file_reader.h index 67c1247fa97cc43e28064b4e0da81812f41b231a..5820c1e9294c76f0f777a6e7cfae9cde7ebf490f 100644 --- a/include/caosdb/file_transmission/file_reader.h +++ b/include/caosdb/file_transmission/file_reader.h @@ -52,6 +52,7 @@ #include <boost/filesystem/fstream.hpp> // for ifstream #include <boost/filesystem/operations.hpp> // for exists #include <boost/filesystem/path.hpp> // for path +#include <cstddef> // for size_t #include <fstream> // for ifstream, size_t #include <string> // for string diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt index aefe6846d23f2cc3a145cbf6158101e7e1bb3df4..9cacb63b0f6b74368508df6920e2dc03db81a929 100644 --- a/test/CMakeLists.txt +++ b/test/CMakeLists.txt @@ -41,7 +41,7 @@ set(test_cases # special linting for tests set(_CMAKE_CXX_CLANG_TIDY_TEST_CHECKS - "${_CMAKE_CXX_CLANG_TIDY_CHECKS},-cert-err58-cpp,-cppcoreguidelines-avoid-non-const-global-variables,-cppcoreguidelines-owning-memory,-modernize-use-trailing-return-type,-google-readability-avoid-underscore-in-googletest-name,-cppcoreguidelines-avoid-magic-numbers,-readability-magic-numbers,-cppcoreguidelines-avoid-goto,-hicpp-avoid-goto,-readability-function-cognitive-complexity,-cppcoreguidelines-non-private-member-variables-in-classes,-misc-non-private-member-variables-in-classes" + "${_CMAKE_CXX_CLANG_TIDY_CHECKS},-cert-err58-cpp,-cppcoreguidelines-avoid-non-const-global-variables,-cppcoreguidelines-owning-memory,-modernize-use-trailing-return-type,-google-readability-avoid-underscore-in-googletest-name,-cppcoreguidelines-avoid-magic-numbers,-readability-magic-numbers,-cppcoreguidelines-avoid-goto,-hicpp-avoid-goto,-readability-function-cognitive-complexity,-cppcoreguidelines-non-private-member-variables-in-classes,-misc-non-private-member-variables-in-classes,-clang-analyzer-cplusplus.Move" ) # add special cmake functions for gtest diff --git a/test/test_data_type.cpp b/test/test_data_type.cpp index cc59a6592fcc49a7d2b62413a8354bb9e3ba79e6..b1e714d705b23dcaef6354e17cf94e411f1d8335 100644 --- a/test/test_data_type.cpp +++ b/test/test_data_type.cpp @@ -134,7 +134,7 @@ TEST(test_data_type, data_type_copy_constructor) { const auto dt_string = data_type.ToString(); // copy - const DataType copy_data_type(data_type); + const DataType copy_data_type(data_type); // NOLINT (explicit copy) EXPECT_EQ(copy_data_type, data_type); EXPECT_EQ(dt_string, copy_data_type.ToString()); } @@ -146,9 +146,9 @@ TEST(test_data_type, data_type_move_constructor) { // copy for testing const DataType copy_data_type(data_type); // move - const DataType move_data_type(std::move(data_type)); - EXPECT_NE(data_type, copy_data_type); // NOLINT - EXPECT_NE(data_type.ToString(), dt_string); // NOLINT + const DataType move_data_type(std::move(data_type)); // NOLINT + EXPECT_NE(data_type, copy_data_type); // NOLINT + EXPECT_NE(data_type.ToString(), dt_string); // NOLINT EXPECT_EQ(copy_data_type, move_data_type); EXPECT_EQ(move_data_type.ToString(), dt_string); @@ -159,7 +159,7 @@ TEST(test_data_type, data_type_copy_assignment) { const auto dt_string = data_type.ToString(); // copy - DataType copy_data_type = data_type; + DataType copy_data_type = data_type; // NOLINT (explicit copy) EXPECT_EQ(copy_data_type, data_type); EXPECT_EQ(dt_string, copy_data_type.ToString()); } @@ -171,9 +171,9 @@ TEST(test_data_type, data_type_move_assignment) { // copy for testing const DataType copy_data_type(data_type); // move - DataType move_data_type = std::move(data_type); - EXPECT_NE(data_type, copy_data_type); // NOLINT - EXPECT_NE(data_type.ToString(), dt_string); // NOLINT + DataType move_data_type = std::move(data_type); // NOLINT + EXPECT_NE(data_type, copy_data_type); // NOLINT + EXPECT_NE(data_type.ToString(), dt_string); // NOLINT EXPECT_EQ(copy_data_type, move_data_type); EXPECT_EQ(move_data_type.ToString(), dt_string);