From 8863d608fea552852393310938fb803acb1f5f39 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Henrik=20tom=20W=C3=B6rden?= <henrik@trineo.org>
Date: Mon, 16 Aug 2021 16:29:27 +0200
Subject: [PATCH] MAINT: add todos for linting errors
---
src/caosdb/file_transmission/FileReader.cpp | 4 +++-
src/caosdb/file_transmission/FileWriter.cpp | 5 ++++-
src/caosdb/transaction.cpp | 6 ++++--
3 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/src/caosdb/file_transmission/FileReader.cpp b/src/caosdb/file_transmission/FileReader.cpp
index 5124846..b1f9789 100644
--- a/src/caosdb/file_transmission/FileReader.cpp
+++ b/src/caosdb/file_transmission/FileReader.cpp
@@ -43,7 +43,9 @@ std::size_t FileReader::read(std::string &buffer) {
if (!stream_.eof()) {
auto bufferSize = buffer.size();
if (bufferSize > 0) {
- if (!stream_.read(&buffer[0], bufferSize)) {
+ // TODO(tf) error: narrowing conversion from 'unsigned long' to signed
+ // type 'std::streamsize' (aka 'long').
+ if (!stream_.read(&buffer[0], bufferSize)) { // NOLINT
throw FileIOError("Can't read file: " + filename_.string());
}
diff --git a/src/caosdb/file_transmission/FileWriter.cpp b/src/caosdb/file_transmission/FileWriter.cpp
index 3d89c1c..4d115bb 100644
--- a/src/caosdb/file_transmission/FileWriter.cpp
+++ b/src/caosdb/file_transmission/FileWriter.cpp
@@ -34,7 +34,10 @@ void FileWriter::openFile() {
void FileWriter::write(const std::string &buffer) {
auto bufferSize = buffer.size();
if (bufferSize > 0) {
- if (!stream_.write(buffer.data(), bufferSize)) {
+ // TODO(tf) error: narrowing conversion from 'unsigned long' to signed type
+ // 'std::streamsize' (aka 'long').
+ // NOLINT
+ if (!stream_.write(buffer.data(), bufferSize)) { // NOLINT
throw FileIOError("Can't write file: " + filename_.string());
}
}
diff --git a/src/caosdb/transaction.cpp b/src/caosdb/transaction.cpp
index 377b3b0..663af17 100644
--- a/src/caosdb/transaction.cpp
+++ b/src/caosdb/transaction.cpp
@@ -257,7 +257,8 @@ auto Transaction::Execute() -> TransactionStatus {
return status;
}
-auto Transaction::ExecuteAsynchronously() noexcept -> StatusCode {
+// TODO(tf) This has apparently a cognitive complexity of 39>25 (threshold).
+auto Transaction::ExecuteAsynchronously() noexcept -> StatusCode { // NOLINT
if (!IsStatus(TransactionStatus::READY()) &&
!IsStatus(TransactionStatus::GO_ON())) {
return StatusCode::TRANSACTION_STATUS_ERROR;
@@ -356,7 +357,8 @@ auto Transaction::ExecuteAsynchronously() noexcept -> StatusCode {
return StatusCode::EXECUTING;
}
-auto Transaction::WaitForIt() const noexcept -> TransactionStatus {
+// TODO(tf) This has apparently a cognitive complexity of 36>25 (threshold).
+auto Transaction::WaitForIt() const noexcept -> TransactionStatus { // NOLINT
bool set_error = false;
auto *responses = this->response->mutable_responses();
std::vector<std::unique_ptr<Entity>> entities;
--
GitLab