From 1f5f6dec83898181f0b633264c9207797c45fce9 Mon Sep 17 00:00:00 2001
From: Timm Fitschen <t.fitschen@indiscale.com>
Date: Mon, 21 Nov 2022 14:04:10 +0100
Subject: [PATCH] MAINT: cleanup transaction.h
---
include/caosdb/transaction.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/include/caosdb/transaction.h b/include/caosdb/transaction.h
index 3a63556..b1d3bee 100644
--- a/include/caosdb/transaction.h
+++ b/include/caosdb/transaction.h
@@ -342,10 +342,6 @@ public:
CAOSDB_LOG_ERROR(logger_name)
<< "GetResultTable was called before the transaction has terminated. This is a programming "
"error of the code which uses the transaction.";
- // TODO(tf) This is a really bad SegFault factory. When the transaction
- // terminates and the result_set is being overriden, the unique_ptr
- // created here will be deleted and any client of the return ResultTable
- // will have a SegFault.
} else if (this->GetStatus().GetCode() == StatusCode::SPOILED) {
CAOSDB_LOG_ERROR(logger_name)
<< "GetResultTable was called on a \"spoiled\" transaction. That means "
--
GitLab