From ea6cd246cf79c11939d1b45d5a6cbff4e2889a9a Mon Sep 17 00:00:00 2001
From: fspreck <f.spreckelsen@indiscale.com>
Date: Mon, 21 Mar 2022 16:21:56 +0100
Subject: [PATCH] FIX: Don't use name "1" for test property
---
.../datamodel_atomic_properties.schema.json | 4 ++--
unittests/test_json_schema_model_parser.py | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/unittests/json-schema-models/datamodel_atomic_properties.schema.json b/unittests/json-schema-models/datamodel_atomic_properties.schema.json
index 97a67b1c..5becf457 100644
--- a/unittests/json-schema-models/datamodel_atomic_properties.schema.json
+++ b/unittests/json-schema-models/datamodel_atomic_properties.schema.json
@@ -6,9 +6,9 @@
"properties": {
"title": { "type": "string", "description": "full dataset title" },
"campaign": { "type": "string", "description": "FIXME" },
- "1": { "type": "number", "description": "Some float property" }
+ "number_prop": { "type": "number", "description": "Some float property" }
},
- "required": [ "title", "1" ]
+ "required": [ "title", "number_prop" ]
},
{
"title": "Dataset2",
diff --git a/unittests/test_json_schema_model_parser.py b/unittests/test_json_schema_model_parser.py
index 8e67eb18..2845953f 100644
--- a/unittests/test_json_schema_model_parser.py
+++ b/unittests/test_json_schema_model_parser.py
@@ -85,7 +85,7 @@ def test_datamodel_with_atomic_properties():
assert rt1.get_property("title") is not None
assert rt1.get_property("campaign") is not None
- assert rt1.get_property("1") is not None
+ assert rt1.get_property("number_prop") is not None
title_prop = rt1.get_property("title")
assert title_prop.datatype == db.TEXT
@@ -95,7 +95,7 @@ def test_datamodel_with_atomic_properties():
assert campaign_prop.datatype == db.TEXT
assert rt1.get_importance(campaign_prop.name) == db.RECOMMENDED
- float_prop = rt1.get_property("1")
+ float_prop = rt1.get_property("number_prop")
assert float_prop.datatype == db.DOUBLE
assert rt1.get_importance(float_prop.name) == db.OBLIGATORY
--
GitLab